From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v3] libxl/libxl_qmp.c: fix error handling in qmp_open Date: Fri, 20 Mar 2015 10:08:43 +0000 Message-ID: <20150320100843.GL16267@zion.uk.xensource.com> References: <1426747230-30579-1-git-send-email-pramod.devendra@citrix.com> <1426769712-1524-1-git-send-email-pramod.devendra@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YYtrH-0000iL-AS for xen-devel@lists.xenproject.org; Fri, 20 Mar 2015 10:08:51 +0000 Content-Disposition: inline In-Reply-To: <1426769712-1524-1-git-send-email-pramod.devendra@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: PRAMOD DEVENDRA Cc: xen-devel@lists.xenproject.org, Wei Liu , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thu, Mar 19, 2015 at 12:55:12PM +0000, PRAMOD DEVENDRA wrote: > From: Pramod Devendra > > 1. Make sure sun_path does not overflow > 2. Close qmp_fd on error > 3. Use goto out for error handling > > Signed-off-by: Pramod Devendra > CC: Ian Jackson > CC: Stefano Stabellini > CC: Ian Campbell > CC: Wei Liu Acked-by: Wei Liu