From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751159AbbCTMZJ (ORCPT ); Fri, 20 Mar 2015 08:25:09 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:37921 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbbCTMZH (ORCPT ); Fri, 20 Mar 2015 08:25:07 -0400 From: Grant Likely Subject: Re: [PATCH 1/2] of: Allow selection of OF_DYNAMIC and OF_OVERLAY if OF_UNITTEST To: Geert Uytterhoeven , Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven In-Reply-To: <1422029405-9353-2-git-send-email-geert+renesas@glider.be> References: <1422029405-9353-1-git-send-email-geert+renesas@glider.be> <1422029405-9353-2-git-send-email-geert+renesas@glider.be> Date: Fri, 20 Mar 2015 12:25:02 +0000 Message-Id: <20150320122502.EB491C40724@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Jan 2015 17:10:04 +0100 , Geert Uytterhoeven wrote: > Currently OF_DYNAMIC and OF_OVERLAY are not visible to the user, and are > selected automatically only when needed. > > Allow them to be enabled manually to improve device tree unit test > coverage. > > Signed-off-by: Geert Uytterhoeven I like the change. Merged, thanks. g. > --- > drivers/of/Kconfig | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > index 38d1c51f58b108db..e9301686493933cc 100644 > --- a/drivers/of/Kconfig > +++ b/drivers/of/Kconfig > @@ -34,7 +34,11 @@ config OF_PROMTREE > # Hardly any platforms need this. It is safe to select, but only do so if you > # need it. > config OF_DYNAMIC > - bool > + bool "Support for dynamic device trees" if OF_UNITTEST > + help > + On some platforms, the device tree can be manipulated at runtime. > + While this option is selected automatically on such platforms, you > + can enable it manually to improve device tree unit test coverage. > > config OF_ADDRESS > def_bool y > @@ -84,9 +88,14 @@ config OF_RESOLVE > bool > > config OF_OVERLAY > - bool > + bool "Support for device tree overlays" if OF_UNITTEST > depends on OF > select OF_DYNAMIC > select OF_RESOLVE > + help > + Overlays are a method to dynamically modify part of the kernel's > + device tree with dynamically loaded data. > + While this option is selected automatically when needed, you can > + enable it manually to improve device tree unit test coverage. > > endmenu # OF > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 1/2] of: Allow selection of OF_DYNAMIC and OF_OVERLAY if OF_UNITTEST Date: Fri, 20 Mar 2015 12:25:02 +0000 Message-ID: <20150320122502.EB491C40724@trevor.secretlab.ca> References: <1422029405-9353-1-git-send-email-geert+renesas@glider.be> <1422029405-9353-2-git-send-email-geert+renesas@glider.be> Return-path: In-Reply-To: <1422029405-9353-2-git-send-email-geert+renesas@glider.be> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven List-Id: devicetree@vger.kernel.org On Fri, 23 Jan 2015 17:10:04 +0100 , Geert Uytterhoeven wrote: > Currently OF_DYNAMIC and OF_OVERLAY are not visible to the user, and are > selected automatically only when needed. > > Allow them to be enabled manually to improve device tree unit test > coverage. > > Signed-off-by: Geert Uytterhoeven I like the change. Merged, thanks. g. > --- > drivers/of/Kconfig | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > index 38d1c51f58b108db..e9301686493933cc 100644 > --- a/drivers/of/Kconfig > +++ b/drivers/of/Kconfig > @@ -34,7 +34,11 @@ config OF_PROMTREE > # Hardly any platforms need this. It is safe to select, but only do so if you > # need it. > config OF_DYNAMIC > - bool > + bool "Support for dynamic device trees" if OF_UNITTEST > + help > + On some platforms, the device tree can be manipulated at runtime. > + While this option is selected automatically on such platforms, you > + can enable it manually to improve device tree unit test coverage. > > config OF_ADDRESS > def_bool y > @@ -84,9 +88,14 @@ config OF_RESOLVE > bool > > config OF_OVERLAY > - bool > + bool "Support for device tree overlays" if OF_UNITTEST > depends on OF > select OF_DYNAMIC > select OF_RESOLVE > + help > + Overlays are a method to dynamically modify part of the kernel's > + device tree with dynamically loaded data. > + While this option is selected automatically when needed, you can > + enable it manually to improve device tree unit test coverage. > > endmenu # OF > -- > 1.9.1 >