From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bh-25.webhostbox.net (bh-25.webhostbox.net [208.91.199.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 1A6B71A2AA9 for ; Sat, 21 Mar 2015 02:28:18 +1100 (AEDT) Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1YYyqO-002oiH-24 for linuxppc-dev@lists.ozlabs.org; Fri, 20 Mar 2015 15:28:16 +0000 Date: Fri, 20 Mar 2015 08:27:02 -0700 From: Guenter Roeck To: Cedric Le Goater Subject: Re: [PATCH v2 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype Message-ID: <20150320152702.GB10749@roeck-us.net> References: <1423117857-32759-1-git-send-email-clg@fr.ibm.com> <1426787085-9004-5-git-send-email-clg@fr.ibm.com> <550BD50E.2040009@fr.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <550BD50E.2040009@fr.ibm.com> Cc: Stewart Smith , lm-sensors@lm-sensors.org, Neelesh Gupta , skiboot@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, Jean Delvare List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Mar 20, 2015 at 09:06:38AM +0100, Cedric Le Goater wrote: > [ ... ] > > > > @@ -265,10 +261,17 @@ static int create_device_attrs(struct pl > > > > sdata[count].id = sensor_id; > > sdata[count].type = type; > > - err = create_hwmon_attr_name(&pdev->dev, type, np->name, > > - sdata[count].name); > > - if (err) > > + > > + attr_name = parse_opal_node_name(np->name, type, &opal_index); > > + if (IS_ERR(attr_name)) { > > + dev_err(&pdev->dev, "Sensor device node name '%s' is invalid\n", > > + np->name); > > + err = IS_ERR(attr_name); > ^^^^^^ > > Arg. Bad copy/paste. This should be PTR_ERR() ... > > Do you want a full patchset resend or just a resend of this patch ? or a fix maybe. > No need to resend; I fixed it up. Thanks, Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Fri, 20 Mar 2015 15:27:02 +0000 Subject: Re: [lm-sensors] [PATCH v2 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype Message-Id: <20150320152702.GB10749@roeck-us.net> List-Id: References: <1423117857-32759-1-git-send-email-clg@fr.ibm.com> <1426787085-9004-5-git-send-email-clg@fr.ibm.com> <550BD50E.2040009@fr.ibm.com> In-Reply-To: <550BD50E.2040009@fr.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Cedric Le Goater Cc: Stewart Smith , lm-sensors@lm-sensors.org, Neelesh Gupta , skiboot@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, Jean Delvare On Fri, Mar 20, 2015 at 09:06:38AM +0100, Cedric Le Goater wrote: > [ ... ] > > > > @@ -265,10 +261,17 @@ static int create_device_attrs(struct pl > > > > sdata[count].id = sensor_id; > > sdata[count].type = type; > > - err = create_hwmon_attr_name(&pdev->dev, type, np->name, > > - sdata[count].name); > > - if (err) > > + > > + attr_name = parse_opal_node_name(np->name, type, &opal_index); > > + if (IS_ERR(attr_name)) { > > + dev_err(&pdev->dev, "Sensor device node name '%s' is invalid\n", > > + np->name); > > + err = IS_ERR(attr_name); > ^^^^^^ > > Arg. Bad copy/paste. This should be PTR_ERR() ... > > Do you want a full patchset resend or just a resend of this patch ? or a fix maybe. > No need to resend; I fixed it up. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors