From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hyong-Youb Kim Subject: Re: [PATCH v1 21/47] ethernet: myri10ge: use arch_phys_wc_add() Date: Sat, 21 Mar 2015 16:08:00 +0900 Message-ID: <20150321070759.GB8766__28311.5848120817$1427098986$gmane$org@gtest01.arcus> References: <1426893517-2511-1-git-send-email-mcgrof@do-not-panic.com> <1426893517-2511-22-git-send-email-mcgrof@do-not-panic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YZDWY-00054g-8q for xen-devel@lists.xenproject.org; Sat, 21 Mar 2015 07:08:46 +0000 Content-Disposition: inline In-Reply-To: <1426893517-2511-22-git-send-email-mcgrof@do-not-panic.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Luis R. Rodriguez" Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , JBeulich@suse.com, hpa@zytor.com, suresh.b.siddha@intel.com, Tomi Valkeinen , x86@kernel.org, mingo@redhat.com, xen-devel@lists.xenproject.org, Ingo Molnar , bp@suse.de, Jean-Christophe Plagniol-Villard , Antonino Daplas , "Luis R. Rodriguez" , airlied@redhat.com, tglx@linutronix.de, jgross@suse.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, Hyong-Youb Kim , venkatesh.pallipadi@intel.com List-Id: xen-devel@lists.xenproject.org On Fri, Mar 20, 2015 at 04:18:11PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already uses ioremap_wc() on the same range > so when write-combining is available that will be used > instead. > [...] > --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c [...] > @@ -1984,7 +1979,6 @@ myri10ge_get_ethtool_stats(struct net_device *netdev, > data[i] = ((u64 *)&link_stats)[i]; > > data[i++] = (unsigned int)mgp->tx_boundary; > - data[i++] = (unsigned int)mgp->wc_enabled; > data[i++] = (unsigned int)mgp->pdev->irq; > data[i++] = (unsigned int)mgp->msi_enabled; > data[i++] = (unsigned int)mgp->msix_enabled; You would have to delete "WC from myri10ge_gstrings_main_stats too. Something like below. Thanks. @@ -1905,7 +1905,7 @@ static const char myri10ge_gstrings_main_stats[][ETH_GSTRING_LEN] = { "tx_aborted_errors", "tx_carrier_errors", "tx_fifo_errors", "tx_heartbeat_errors", "tx_window_errors", /* device-specific stats */ - "tx_boundary", "WC", "irq", "MSI", "MSIX", + "tx_boundary", "irq", "MSI", "MSIX", "read_dma_bw_MBs", "write_dma_bw_MBs", "read_write_dma_bw_MBs", "serial_number", "watchdog_resets", #ifdef CONFIG_MYRI10GE_DCA