From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbbCVClK (ORCPT ); Sat, 21 Mar 2015 22:41:10 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:52444 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbbCVClH (ORCPT ); Sat, 21 Mar 2015 22:41:07 -0400 From: Arnd Bergmann Organization: Linaro Ltd To: Richard Cochran Subject: Re: [PATCH net-next V2 13/23] ptp: igb: convert to the 64 bit get/set time methods. Date: Sun, 22 Mar 2015 03:40:16 +0100 User-Agent: KMail/1.12.2 (Linux/3.8.0-35-generic; KDE/4.3.2; x86_64; ; ) Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Amir Vadai , Ariel Elior , Baolin Wang , Ben Hutchings , Bruce Allan , Carolyn Wyborny , Chris Metcalf , David Miller , Frank Li , Giuseppe Cavallaro , Jeff Kirsher , John Stultz , Luwei Zhou , Matthew Vick , Michael Chan , Prashant Sreedharan , Shradha Shah , Solarflare linux maintainers , Sonic Zhang , Stefan =?iso-8859-15?q?S=F8rensen?= , Thomas Gleixner , Tom Lendacky References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201503220340.16405.arnd@linaro.org> X-Provags-ID: V03:K0:rmxutFIuoV2MDZyyTCv5dshnfF7QME2T38dGW9GHXp4hW1Qujgw EXrtuCsZiTScrTJijX9SFrwD/mZBnE9pAakyooHGvFYWbRMEKtiQDcjZQb84tHX7Pf/mHkQ pimqNpIbXXH5fB/t6M32eYZKYRIvnRq7Tup+dO7JhipcjUz2tN+eTg600k5B1YMgwJgowN8 ZdLup+3+IvnI7Zk9TFC3g== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 21 March 2015, Richard Cochran wrote: > @@ -269,13 +270,13 @@ static int igb_ptp_adjtime_i210(struct ptp_clock_info *ptp, s64 delta) > struct igb_adapter *igb = container_of(ptp, struct igb_adapter, > ptp_caps); > unsigned long flags; > - struct timespec now, then = ns_to_timespec(delta); > + struct timespec64 now, then = ns_to_timespec64(delta); > > spin_lock_irqsave(&igb->tmreg_lock, flags); > > igb_ptp_read_i210(igb, &now); > - now = timespec_add(now, then); > - igb_ptp_write_i210(igb, (const struct timespec *)&now); > + now = timespec64_add(now, then); > + igb_ptp_write_i210(igb, (const struct timespec64 *)&now); > > spin_unlock_irqrestore(&igb->tmreg_lock, flags); > This is one of the functions that would actually become more efficient if the argument type gets changed to ktime_t. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH net-next V2 13/23] ptp: igb: convert to the 64 bit get/set time methods. Date: Sun, 22 Mar 2015 03:40:16 +0100 Message-ID: <201503220340.16405.arnd@linaro.org> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Amir Vadai , Ariel Elior , Baolin Wang , Ben Hutchings , Bruce Allan , Carolyn Wyborny , Chris Metcalf , David Miller , Frank Li , Giuseppe Cavallaro , Jeff Kirsher , John Stultz , Luwei Zhou , Matthew Vick , Michael Chan , Prashant Sreedharan , Shradha Shah , Solarflare linux maintainers , Sonic Zhang , Stefan =?iso-8859-15?q?S=F8rensen?= Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Saturday 21 March 2015, Richard Cochran wrote: > @@ -269,13 +270,13 @@ static int igb_ptp_adjtime_i210(struct ptp_clock_info *ptp, s64 delta) > struct igb_adapter *igb = container_of(ptp, struct igb_adapter, > ptp_caps); > unsigned long flags; > - struct timespec now, then = ns_to_timespec(delta); > + struct timespec64 now, then = ns_to_timespec64(delta); > > spin_lock_irqsave(&igb->tmreg_lock, flags); > > igb_ptp_read_i210(igb, &now); > - now = timespec_add(now, then); > - igb_ptp_write_i210(igb, (const struct timespec *)&now); > + now = timespec64_add(now, then); > + igb_ptp_write_i210(igb, (const struct timespec64 *)&now); > > spin_unlock_irqrestore(&igb->tmreg_lock, flags); > This is one of the functions that would actually become more efficient if the argument type gets changed to ktime_t. Arnd