From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751809AbbCVH3o (ORCPT <rfc822;w@1wt.eu>);
	Sun, 22 Mar 2015 03:29:44 -0400
Received: from mail-wi0-f182.google.com ([209.85.212.182]:38636 "EHLO
	mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751674AbbCVH3l (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 22 Mar 2015 03:29:41 -0400
Date: Sun, 22 Mar 2015 08:29:35 +0100
From: Richard Cochran <richardcochran@gmail.com>
To: Arnd Bergmann <arnd@linaro.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Amir Vadai <amirv@mellanox.com>, Ariel Elior <ariel.elior@qlogic.com>,
        Baolin Wang <baolin.wang@linaro.org>,
        Ben Hutchings <ben@decadent.org.uk>,
        Bruce Allan <bruce.w.allan@intel.com>,
        Carolyn Wyborny <carolyn.wyborny@intel.com>,
        Chris Metcalf <cmetcalf@ezchip.com>,
        David Miller <davem@davemloft.net>, Frank Li <Frank.Li@freescale.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        John Stultz <john.stultz@linaro.org>,
        Luwei Zhou <b45643@freescale.com>,
        Matthew Vick <matthew.vick@intel.com>,
        Michael Chan <mchan@broadcom.com>,
        Prashant Sreedharan <prashant@broadcom.com>,
        Shradha Shah <sshah@solarflare.com>,
        Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
        Sonic Zhang <sonic.zhang@analog.com>,
        Stefan =?iso-8859-1?Q?S=F8rensen?= 
	<stefan.sorensen@spectralink.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit
 get/set time methods.
Message-ID: <20150322072935.GB4254@localhost.localdomain>
References: <cover.1426973658.git.richardcochran@gmail.com>
 <55b6ec7c2e0c72a79762748981fad2ce2497f22d.1426973658.git.richardcochran@gmail.com>
 <201503220336.31836.arnd@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201503220336.31836.arnd@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 22, 2015 at 03:36:31AM +0100, Arnd Bergmann wrote:
> On Saturday 21 March 2015, Richard Cochran wrote:
> >         mutex_lock(&clock->extreg_lock);
> >  
> > -       err = tdr_write(1, phydev, ts, PTP_LOAD_CLK);
> > +       err = tdr_write(1, phydev, &ts, PTP_LOAD_CLK);
> >  
> >         mutex_unlock(&clock->extreg_lock);
> 
> I don't see the change to the tdr_write() function that changes the 
> argument from 'struct timespec ts' to 'struct timespec64 *', so this
> looks wrong to me.

There is a 'ts64' parameter, converted to 'ts' beforehand.

Thanks,
Richard

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit
 get/set time methods.
Date: Sun, 22 Mar 2015 08:29:35 +0100
Message-ID: <20150322072935.GB4254@localhost.localdomain>
References: <cover.1426973658.git.richardcochran@gmail.com>
 <55b6ec7c2e0c72a79762748981fad2ce2497f22d.1426973658.git.richardcochran@gmail.com>
 <201503220336.31836.arnd@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Amir Vadai <amirv@mellanox.com>,
	Ariel Elior <ariel.elior@qlogic.com>,
	Baolin Wang <baolin.wang@linaro.org>,
	Ben Hutchings <ben@decadent.org.uk>,
	Bruce Allan <bruce.w.allan@intel.com>,
	Carolyn Wyborny <carolyn.wyborny@intel.com>,
	Chris Metcalf <cmetcalf@ezchip.com>,
	David Miller <davem@davemloft.net>,
	Frank Li <Frank.Li@freescale.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	John Stultz <john.stultz@linaro.org>,
	Luwei Zhou <b45643@freescale.com>,
	Matthew Vick <matthew.vick@intel.com>,
	Michael Chan <mchan@broadcom.com>,
	Prashant Sreedharan <prashant@broadcom.com>,
	Shradha Shah <sshah@solarflare.com>,
	Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
	Sonic Zhang <sonic.zhang@analog.com>,
	Stefan =?iso-8859-1?Q?S=F8rensen?=
	<stefan.sorensen@spectrali
To: Arnd Bergmann <arnd@linaro.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <201503220336.31836.arnd@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Sun, Mar 22, 2015 at 03:36:31AM +0100, Arnd Bergmann wrote:
> On Saturday 21 March 2015, Richard Cochran wrote:
> >         mutex_lock(&clock->extreg_lock);
> >  
> > -       err = tdr_write(1, phydev, ts, PTP_LOAD_CLK);
> > +       err = tdr_write(1, phydev, &ts, PTP_LOAD_CLK);
> >  
> >         mutex_unlock(&clock->extreg_lock);
> 
> I don't see the change to the tdr_write() function that changes the 
> argument from 'struct timespec ts' to 'struct timespec64 *', so this
> looks wrong to me.

There is a 'ts64' parameter, converted to 'ts' beforehand.

Thanks,
Richard