All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: sfeldma@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v6] switchdev: fix stp update API to work with layered netdevices
Date: Mon, 23 Mar 2015 16:45:25 -0400 (EDT)	[thread overview]
Message-ID: <20150323.164525.1089841738578904403.davem@davemloft.net> (raw)
In-Reply-To: <1426958848-2781-1-git-send-email-roopa@cumulusnetworks.com>

From: roopa@cumulusnetworks.com
Date: Sat, 21 Mar 2015 10:27:28 -0700

> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> make it same as the netdev_switch_port_bridge_setlink/dellink
> api (ie traverse lowerdevs to get to the switch port).
> 
> removes "WARN_ON(!ops->ndo_switch_parent_id_get)" because
> direct bridge ports can be stacked netdevices (like bonds
> and team of switch ports) which may not implement this ndo.
> 
> v2 to v3:
> 	- remove changes to bond and team. Bring back the
> 	transparently following lowerdevs like i initially
> 	had for setlink/getlink
> 	(http://www.spinics.net/lists/netdev/msg313436.html)
> 	dave and scott feldman also seem to prefer it be that
> 	way and move to non-transparent way of doing things
> 	if we see a problem down the lane.
> 
> v3 to v4:
> 	- fix ret initialization
> 
> v4 to v5:
> 	- return err on first failure (scott feldman)
> 
> v5 to v6:
> 	- change variable name (err) and initialize to
> 	-EOPNOTSUPP (scott feldman).
> 
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Applied, thank you.

      parent reply	other threads:[~2015-03-23 20:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-21 17:27 [PATCH net-next v6] switchdev: fix stp update API to work with layered netdevices roopa
2015-03-22  3:21 ` Scott Feldman
2015-03-23  6:25 ` Jiri Pirko
2015-03-23 20:45 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150323.164525.1089841738578904403.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.