From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752214AbbCWILD (ORCPT ); Mon, 23 Mar 2015 04:11:03 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:34299 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbbCWIKr (ORCPT ); Mon, 23 Mar 2015 04:10:47 -0400 Date: Mon, 23 Mar 2015 09:10:40 +0100 From: Richard Cochran To: Arnd Bergmann Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Amir Vadai , Ariel Elior , Baolin Wang , Ben Hutchings , Bruce Allan , Carolyn Wyborny , Chris Metcalf , David Miller , Frank Li , Giuseppe Cavallaro , Jeff Kirsher , John Stultz , Luwei Zhou , Matthew Vick , Michael Chan , Prashant Sreedharan , Shradha Shah , Solarflare linux maintainers , Sonic Zhang , Stefan =?iso-8859-1?Q?S=F8rensen?= , Thomas Gleixner , Tom Lendacky Subject: Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods. Message-ID: <20150323081040.GA4779@localhost.localdomain> References: <201503220336.31836.arnd@linaro.org> <20150322072935.GB4254@localhost.localdomain> <201503221848.02226.arnd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201503221848.02226.arnd@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 22, 2015 at 06:48:02PM +0100, Arnd Bergmann wrote: > Ok, got it. The code looks correct then, though I'd like to see the use > of 'timespec' pushed out as far as possible. How about changing the > type for tdr_write() as well here? > > tdr_write() itself should be fine until 2106, as it writes an unsigned number, > but it's probably good to document that inside of that function. Arnd, thanks for the careful review. I will work out follow up patches for this driver and the i210 (igb) to address the remaining issues. For this series, lets leave tdr_write as is now, but I will surely take another look for the fix. Thanks, Richard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods. Date: Mon, 23 Mar 2015 09:10:40 +0100 Message-ID: <20150323081040.GA4779@localhost.localdomain> References: <201503220336.31836.arnd@linaro.org> <20150322072935.GB4254@localhost.localdomain> <201503221848.02226.arnd@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Amir Vadai , Ariel Elior , Baolin Wang , Ben Hutchings , Bruce Allan , Carolyn Wyborny , Chris Metcalf , David Miller , Frank Li , Giuseppe Cavallaro , Jeff Kirsher , John Stultz , Luwei Zhou , Matthew Vick , Michael Chan , Prashant Sreedharan , Shradha Shah , Solarflare linux maintainers , Sonic Zhang , Stefan =?iso-8859-1?Q?S=F8rensen?= Return-path: Content-Disposition: inline In-Reply-To: <201503221848.02226.arnd@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, Mar 22, 2015 at 06:48:02PM +0100, Arnd Bergmann wrote: > Ok, got it. The code looks correct then, though I'd like to see the use > of 'timespec' pushed out as far as possible. How about changing the > type for tdr_write() as well here? > > tdr_write() itself should be fine until 2106, as it writes an unsigned number, > but it's probably good to document that inside of that function. Arnd, thanks for the careful review. I will work out follow up patches for this driver and the i210 (igb) to address the remaining issues. For this series, lets leave tdr_write as is now, but I will surely take another look for the fix. Thanks, Richard