From: Alberto Garcia <berto@igalia.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED
Date: Mon, 23 Mar 2015 10:53:11 +0100 [thread overview]
Message-ID: <20150323095311.GA18824@igalia.com> (raw)
In-Reply-To: <87egogt6hs.fsf@blackfin.pond.sub.org>
On Mon, Mar 23, 2015 at 10:20:31AM +0100, Markus Armbruster wrote:
> > +- "device": Device name (json-string)
> > +- "node-name": Node name, if it's present (json-string)
>
> By convention, we mark optional members like this:
>
> - "node-name": Node name (json-string, optional)
You're right, thanks for pointing that out!
This can be fixed when committing the patch, otherwise I can resend
the series again.
> Ignorant question: can "device" be ""? If yes, we should document
> what that means, possibly in a separate patch.
Yes it can be "", the purpose of the patch is precisely to expand the
event with a new field that can identify the node in such cases.
The only reason why it is not optional is to keep backward
compatibility.
But it's true that it can be clarified in the documentation, I can
send a follow-up patch as soon as this one is merged.
Berto
next prev parent reply other threads:[~2015-03-23 9:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 14:33 [Qemu-devel] [PATCH v3 0/3] Add bdrv_get_device_or_node_name() Alberto Garcia
2015-03-20 14:33 ` [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name() Alberto Garcia
2015-03-20 19:11 ` Max Reitz
2015-03-20 14:33 ` [Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages Alberto Garcia
2015-03-20 19:24 ` Max Reitz
2015-03-20 14:33 ` [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED Alberto Garcia
2015-03-20 19:26 ` Max Reitz
2015-03-23 9:20 ` Markus Armbruster
2015-03-23 9:53 ` Alberto Garcia [this message]
2015-03-23 11:55 ` Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2015-04-08 9:29 [Qemu-devel] [PATCH v4 0/3] Add bdrv_get_device_or_node_name() Alberto Garcia
2015-04-08 9:29 ` [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED Alberto Garcia
2015-04-08 23:32 ` Eric Blake
2015-04-09 7:30 ` Alberto Garcia
2015-04-15 13:24 ` Max Reitz
2015-03-20 10:19 [Qemu-devel] [PATCH v2 0/3] Add bdrv_get_device_or_node_name() Alberto Garcia
2015-03-20 10:19 ` [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED Alberto Garcia
2015-03-20 13:24 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323095311.GA18824@igalia.com \
--to=berto@igalia.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.