From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752912AbbCWNSp (ORCPT ); Mon, 23 Mar 2015 09:18:45 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:37822 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbbCWNSm (ORCPT ); Mon, 23 Mar 2015 09:18:42 -0400 Date: Mon, 23 Mar 2015 14:18:39 +0100 From: Jiri Pirko To: Andrei Maresu Cc: Scott Feldman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] Net: ethernet: rocker: fixed a space coding style issue Message-ID: <20150323131839.GB2038@nanopsycho.lan> References: <1426960960-31552-1-git-send-email-andreimaresu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426960960-31552-1-git-send-email-andreimaresu@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sat, Mar 21, 2015 at 07:02:40PM CET, andreimaresu@gmail.com wrote: >Fixed a space coding style issue found by checkpatch.pl in rocker.c > >Signed-off-by: Andrei Maresu >--- > drivers/net/ethernet/rocker/rocker.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c >index 9fb6948..d364b12 100644 >--- a/drivers/net/ethernet/rocker/rocker.c >+++ b/drivers/net/ethernet/rocker/rocker.c >@@ -812,7 +812,7 @@ static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info) > static void rocker_desc_cookie_ptr_set(struct rocker_desc_info *desc_info, > void *ptr) > { >- desc_info->desc->cookie = (uintptr_t) ptr; >+ desc_info->desc->cookie = (uintptr_t)ptr; Checkpatch does not mark this as an error, not even as a warning: "CHECK: No space is necessary after a cast". I personally like the notation with space better. > } > > static struct rocker_desc_info * >-- >1.9.1 > >-- >To unsubscribe from this list: send the line "unsubscribe netdev" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html