From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaHXX-0005hP-MI for qemu-devel@nongnu.org; Tue, 24 Mar 2015 01:38:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaHXW-0005br-Cn for qemu-devel@nongnu.org; Tue, 24 Mar 2015 01:38:11 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:45236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaHXW-0005bU-2d for qemu-devel@nongnu.org; Tue, 24 Mar 2015 01:38:10 -0400 Date: Tue, 24 Mar 2015 16:23:43 +1100 From: David Gibson Message-ID: <20150324052343.GD25043@voom.fritz.box> References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-40-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BeiMt4EphvRJ5ehf" Content-Disposition: inline In-Reply-To: <1424883128-9841-40-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 39/45] Host page!=target page: Cleanup bitmaps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com, yanghy@cn.fujitsu.com --BeiMt4EphvRJ5ehf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 25, 2015 at 04:52:02PM +0000, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > Prior to the start of postcopy, ensure that everything that will > be transferred later is a whole host-page in size. >=20 > This is accomplished by discarding partially transferred host pages > and marking any that are partially dirty as fully dirty. Again, I wonder if this might be a bit more obvious with send/receive_host_page() helpers. Rather than jiggering the basic data structures, you make the code only do the transmission in terms of host page sized chunks, doing the dirty check against all the necessary target page bits. Or better yet, a migration_chunk_size variable, rather than host page size. Initially that would be initialized to host page size, but gives easier flexibility to improve future handling of cases where source hps !=3D dest hps. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --BeiMt4EphvRJ5ehf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVEPTfAAoJEGw4ysog2bOS2jEP+QFN1sRFVYN312v89FlQV5td MRsJtIfHIkdu+SUx0mP4B5yPkCb7vwB52LwafJBCWEm/stb+2PaoQRrjzsDFZaOR hwEt+0Uqk3SuIEmU+BSHB55d9P+uUgUCPOEJ0PuTx2MD0lGmFi61e3SxlcI6JlDQ RHyIRax4Hlxo5XAdX6ChI/qRhcz4EmPEpHqJQuH7sEu56JMz8Y3H1E0VJnVVV3qs fdlBNEmCW5Uc9IZD+iZswFb0LUctJOd8RzU37ASczTKxWuwODKQaPC7XAlV04kZl yRGzAeM1ymdlWHQG/nR7v6rXDJcutHObzDeLi6qmt/SxLEWHnOhZ2U+8JtmA0xhG Rme7ae1U1UNX82iR8UNcgakq2tMZgvfjyFjvoLEiUl2DFgMLP7oZCZ7FuPGt/an8 AqpKYiz4MEC2zGsgRGd7hqA8W8Spji4HNMIp5jILrTWYQm8zGPnRZC+cKwKleRXB doUuTlejRpxrh2MludzYabZ736gsYPPSAcX65nb+M3aeHlPZzIVFTm4EXsPN9AQ/ 4Jmwdih1EAOsjpEZboSY9iUQYYKvMLHQOFyo3QWjxetXxLG+tTt2NCVbGw2StXmp dk1W1cOmWo6XgG5sajIQTy288ITN9kd8WzoQoX8c0FC/3Bp8FXKXlqvPc9XndGCU Bt6lPHitcYVAqObhQ7aK =m6k+ -----END PGP SIGNATURE----- --BeiMt4EphvRJ5ehf--