From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs Date: Tue, 24 Mar 2015 08:50:28 +0000 Message-ID: <20150324085028.GA28609@zion.uk.xensource.com> References: <86C3224E41A7434B904EC364302132D80E478552@SHSMSX101.ccr.corp.intel.com> <1426854029.21742.169.camel@citrix.com> <86C3224E41A7434B904EC364302132D80E4790B3@SHSMSX101.ccr.corp.intel.com> <1427129155.21742.300.camel@citrix.com> <20150323172944.GB19412@zion.uk.xensource.com> <1427132218.21742.310.camel@citrix.com> <86C3224E41A7434B904EC364302132D80E479374@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <86C3224E41A7434B904EC364302132D80E479374@SHSMSX101.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Pang, LongtaoX" Cc: "Ian.Jackson@eu.citrix.com" , "Hu, Robert" , Wei Liu , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Tue, Mar 24, 2015 at 05:13:31AM +0000, Pang, LongtaoX wrote: > > > > -----Original Message----- > > From: Ian Campbell [mailto:ian.campbell@citrix.com] > > Sent: Tuesday, March 24, 2015 1:37 AM > > To: Wei Liu > > Cc: Pang, LongtaoX; Hu, Robert; Ian.Jackson@eu.citrix.com; > > xen-devel@lists.xen.org > > Subject: Re: [Xen-devel] [OSSTEST Nested PATCH 2/6] Add and expose some > > testsupport APIs > > > > On Mon, 2015-03-23 at 17:29 +0000, Wei Liu wrote: > > > On Mon, Mar 23, 2015 at 04:45:55PM +0000, Ian Campbell wrote: > > > > On Mon, 2015-03-23 at 16:20 +0000, Pang, LongtaoX wrote: > > > > > > > > > > > > > > > The editconfig_cd thing -- yet another thing which Ian > > > > > > > > > questioned and which it was agreed you would change but you > > haven't. > > > > > > > > > > > > > > > > > For this question, I have sent a mail about it.(2015-03-04) > > > > > > > > After finishing L1 guest VM installation, we need to change > > > > > > > > L1 guest boot sequence from ISO image to hard disk, we need > > > > > > > > modify the "boot=cd" , > > > > > > > > > > > > > > Do you? As Ian asked before, why is guest_editconfig_nocd not > > > > > > > sufficient? It removes the CD from the virtual drive, meaning > > > > > > > that "boot=dc" will fail to boot from d and fallthru to c. > > > > > > > > > > > > > > > also need to enable 'nestedhvm' feature in hvm configure > > > > > > > > file, > > > > > > > > > > > > > > This certainly doesn't belong in a function called > > > > > > > guest_editconfig_cd, since it has nothing to do with cds at all. > > > > > > > > > > > > > > Anyway, it's not clear why you need to edit this into the > > > > > > > nestedhvm configuration, instead of adding it when the > > > > > > > configuration is created via more_prepareguest_hvm. What harm > > > > > > > is there in enabling this during guest install? > > > > > > > > > > > > > I will try it. > > > > > > > > > > > Re-use 'guest_ediconfig_nocd', after finishing L1 installation, it > > > > > could boot into L1 OS, but failed to install packages( such as > > > > > lvm2, rsync, bridge-utils ....) via Debian repo in L1, as below msg: > > > > > > > > Oh dear. Things really ought to be tailored on install to use the > > > > network repositories for the apt sources, not the cdrom. > > > > > > When I wrote ts-debian-hvm-install, one of the problems (if I remember > > > correctly) was that our network infrastructure didn't support booting > > > EFI from PXE boot. I ended up making that disk image to sort of work > > > around this. > > > > > > > > > > > Installing from netboot rather than netinst media ought to achieve > > > > that, I'm not sure with ts-debian-hvm-install uses though or how to > > > > achieve it via preseeding if it isn't the default for the given media. > > > > > > > > > > Per https://www.debian.org/releases/stable/example-preseed.txt, > > > these runes look interesting. > > > > > > # Additional repositories, local[0-9] available #d-i > > > apt-setup/local0/repository string \ > > > # http://local.server/debian stable main > > > #d-i apt-setup/local0/comment string local server # Enable deb-src > > > lines #d-i apt-setup/local0/source boolean true # URL to the public > > > key of the local repository; you must provide a key # or # apt will > > > complain about the unauthenticated repository and so the # > > > sources.list line will be left commented out #d-i apt-setup/local0/key > > > string http://local.server/key > > > > > > Not sure if they will really end up in source.list though. > > > > My expectation is that the existing preseed will have resulted in both http and > > cdrom entries, and all that is needed is to comment out the cdrom ones so the > > network ones take precedence. > > > > Lets wait for an answer to my question about what is in sources.list on these > > VMs before speculating further on how to fix this though. > > > > Ian. > I have checked the sources.list file in L1 guest, it contains both CDROM repo entry and URL entry(Debian repository mirror location), > Such as below: > deb cdrom:[Debian GNU/Linux 7.6.0 _Wheezy_ - Official amd64 DVD Binary-1 20140712-14:11]/ wheezy contrib main > deb http://linux-ftp.sh.intel.com//pub/mirrors/debian wheezy main > deb-src http://linux-ftp.sh.intel.com//pub/mirrors/debian wheezy main > > It seems that CDROM repo entry take effect, but it definitely unavailable, because ISO image is removed. > If I comment out the CDROM repo entry manually, and then try to 'apt-get install', it works fine. > For wei's first solution that change boot sequence from cd_disc to HDD, it does works and I have created a 'guest_ediconfig_nocd' function about that in previously patchs, maybe it's not preferred according to Ian Campbell's opinion. FWIW I think Ian's approach is better. Using same source to install packages is better than using different sources. > So, maybe I should write some code in 'ts-nested-setup' script to implement ssh into L1, edit sources.list and comment out the CDROM repo entry. Or, do your have some easy ways?