All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Pargmann <mpa@pengutronix.de>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Add required to includes to all files
Date: Tue, 24 Mar 2015 12:35:24 +0100	[thread overview]
Message-ID: <20150324113524.GC28604@pengutronix.de> (raw)
In-Reply-To: <1427035879-24616-2-git-send-email-sven@narfation.org>

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

Hi Sven,

On Sun, Mar 22, 2015 at 03:51:17PM +0100, Sven Eckelmann wrote:
> The source and header files could not be build indepdent from each other. This
> is happened because headers didn't include all includes for anything they've
> used. This was problematic because the success of a build required to know the
> right order of local includes.
> 
> Also source files were not including everything they've used explicitly.
> Instead it required that transient includes are always stable. This is
> problematic because some transient includes are not obvious, depent on config
> settings and may not be stable in the future.
> 
> The order for include blocks are:
> 
>  * primary headers (main.h and the *.h file of a *.c file)
>  * global linux headers
>  * required local headers
>  * extra forward declarations for pointers in function/struct declarations

Thanks for your work. This patch looks really good.

Best Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-03-24 11:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 14:51 [B.A.T.M.A.N.] [PATCH 1/4] batman-adv: Remove explicit compat.h include and split compat.h Sven Eckelmann
2015-03-22 14:51 ` [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Add required to includes to all files Sven Eckelmann
2015-03-24 11:35   ` Markus Pargmann [this message]
2015-03-24 11:39     ` Sven Eckelmann
2015-03-22 14:51 ` [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: Remove unused IFF_BRIDGE_PORT live patching hack Sven Eckelmann
2015-03-22 14:51 ` [B.A.T.M.A.N.] [PATCH 4/4] batman-adv: Automatically create nested kfree_rcu helper functions Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324113524.GC28604@pengutronix.de \
    --to=mpa@pengutronix.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.