From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752271AbbCXMa2 (ORCPT ); Tue, 24 Mar 2015 08:30:28 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:41838 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbbCXMa0 (ORCPT ); Tue, 24 Mar 2015 08:30:26 -0400 Date: Tue, 24 Mar 2015 15:30:21 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Benjamin Romer , David Kershner , Greg Kroah-Hartman , devel@driverdev.osuosl.org, sparmaintainer@unisys.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/4] staging: unisys: remove unneeded comparison Message-ID: <20150324123021.GS10964@mwanda> References: <1427199457-11771-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427199457-11771-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 05:47:34PM +0530, Sudip Mukherjee wrote: > visorchipset_file_cleanup() is called from visorchipset_exit() which > is the module_exit function and this function is executing means > module_init succeeded, so registered will always be true at this time. > and majordev has also been initialized in the init function. hence > these comparisons will always be true. > > Signed-off-by: Sudip Mukherjee This is a partial patch. The "one thing per patch" means don't do half a thing per patch. We now set "registered" but there are no users. regards, dan carpenter