All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andy Gospodarek <gospo@cumulusnetworks.com>
Cc: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
	netdev@vger.kernel.org,
	John Fastabend <john.r.fastabend@intel.com>
Subject: Re: [PATCH iproute2] bridge: drop reference to unused option embedded from manpage
Date: Tue, 24 Mar 2015 14:55:24 -0700	[thread overview]
Message-ID: <20150324145524.491e6435@urahara> (raw)
In-Reply-To: <20150319161419.GA20295@gospo.home.greyhouse.net>

On Thu, 19 Mar 2015 12:14:22 -0400
Andy Gospodarek <gospo@cumulusnetworks.com> wrote:

> On Wed, Mar 18, 2015 at 09:52:11AM +0900, Toshiaki Makita wrote:
> > On 2015/03/18 0:34, Andy Gospodarek wrote:
> > > While looking at the manpage, I noticed a reference to 'embedded' that was
> > > added by this commit:
> > > 
> > > 	commit d611682a8c8f28205158e6d3a7d5e2d01db022cc
> > > 	Author: John Fastabend <john.r.fastabend@intel.com>
> > > 	Date:   Thu Sep 13 23:50:36 2012 -0700
> > > 
> > > 	    iproute2: bridge: finish removing replace option in man pages
> > > 
> > > I no longer see any reference to the 'embedded' option in any c- or h-files, so
> > > it seems worthwhile to remove.
> > 
> > Actually, in addition, "master" option is missing.
> > Also, the current explanation of "self" looks incorrect and appropriate
> > for "master".
> > 
> > I wondered if you could fix them together with this... or I will do later.
> > 
> 
> Good idea, but I would prefer the suggested change as another patch.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

I applied this patch, feel free to do more cleanups in later patches.

      reply	other threads:[~2015-03-24 21:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 15:34 [PATCH iproute2] bridge: drop reference to unused option embedded from manpage Andy Gospodarek
2015-03-18  0:52 ` Toshiaki Makita
2015-03-19 16:14   ` Andy Gospodarek
2015-03-24 21:55     ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324145524.491e6435@urahara \
    --to=stephen@networkplumber.org \
    --cc=gospo@cumulusnetworks.com \
    --cc=john.r.fastabend@intel.com \
    --cc=makita.toshiaki@lab.ntt.co.jp \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.