From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753118AbbCXToI (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 15:44:08 -0400
Received: from mail-wg0-f42.google.com ([74.125.82.42]:34234 "EHLO
	mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752218AbbCXToG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 15:44:06 -0400
Date: Tue, 24 Mar 2015 20:44:02 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Brad Spengler <spender@grsecurity.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andrew Lutomirski <luto@kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        "linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/asm] x86/asm/entry: Add user_mode_ignore_vm86()
Message-ID: <20150324194402.GA27598@gmail.com>
References: <202c56ca63823c338af8e2e54948dbe222da6343.1426728647.git.luto@kernel.org>
 <tip-a67e7277d01ccfd39b0db5a198c2643cc19dd79c@git.kernel.org>
 <CALCETrWZfcRhHogkTC--9aRGOuXuOYuvNdQfrCj0cK3+eNW4jA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrWZfcRhHogkTC--9aRGOuXuOYuvNdQfrCj0cK3+eNW4jA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Andy Lutomirski <luto@amacapital.net> wrote:

> On Mon, Mar 23, 2015 at 5:26 AM, tip-bot for Andy Lutomirski
> <tipbot@zytor.com> wrote:
> > Commit-ID:  a67e7277d01ccfd39b0db5a198c2643cc19dd79c
> > Gitweb:     http://git.kernel.org/tip/a67e7277d01ccfd39b0db5a198c2643cc19dd79c
> > Author:     Andy Lutomirski <luto@kernel.org>
> > AuthorDate: Wed, 18 Mar 2015 18:33:29 -0700
> > Committer:  Ingo Molnar <mingo@kernel.org>
> > CommitDate: Mon, 23 Mar 2015 11:13:36 +0100
> >
> > x86/asm/entry: Add user_mode_ignore_vm86()
> >
> > user_mode() is dangerous and user_mode_vm() has a confusing name.
> >
> > Add user_mode_ignore_vm86() (equivalent to current user_mode()). 
> > We'll change the small number of legitimate users of user_mode() 
> > to user_mode_ignore_vm86().
> >
> > Inspired by grsec, although this works rather differently.
> 
> Ingo, does this mean that you changed your mind or do you still want 
> a patch to delete user_mode_ignore_vm86 and just use user_mode 
> everywhere instead?

Would be still nice to have it as an add on patch, if you agree with 
my arguments.

I picked up your series as-is because it's correct and because it 
already improves things a lot in this area.

Thanks,

	Ingo