From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaZBz-0007CJ-OS for qemu-devel@nongnu.org; Tue, 24 Mar 2015 20:29:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaZBu-0003wD-Pv for qemu-devel@nongnu.org; Tue, 24 Mar 2015 20:29:07 -0400 Date: Wed, 25 Mar 2015 11:07:10 +1100 From: David Gibson Message-ID: <20150325000710.GM25043@voom.fritz.box> References: <1427117764-23008-1-git-send-email-bharata@linux.vnet.ibm.com> <1427117764-23008-3-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jsINjv9JwFjY+Quq" Content-Disposition: inline In-Reply-To: <1427117764-23008-3-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v2 02/23] spapr: Add DRC dt entries for CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de --jsINjv9JwFjY+Quq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 23, 2015 at 07:05:43PM +0530, Bharata B Rao wrote: > Advertise CPU DR-capability to the guest via device tree. >=20 > Signed-off-by: Bharata B Rao > Signed-off-by: Michael Roth > [spapr_drc_reset implementation] > Reviewed-by: David Gibson > --- > hw/ppc/spapr.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) >=20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index a782e28..920e650 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -807,6 +807,15 @@ static void spapr_finalize_fdt(sPAPREnvironment *spa= pr, > spapr_populate_chosen_stdout(fdt, spapr->vio_bus); > } > =20 > + if (spapr->dr_cpu_enabled) { > + int offset =3D fdt_path_offset(fdt, "/cpus"); > + ret =3D spapr_drc_populate_dt(fdt, offset, NULL, > + SPAPR_DR_CONNECTOR_TYPE_CPU); > + if (ret < 0) { > + fprintf(stderr, "Couldn't set up CPU DR device tree properti= es\n"); > + } > + } > + > _FDT((fdt_pack(fdt))); > =20 > if (fdt_totalsize(fdt) > FDT_MAX_SIZE) { > @@ -1393,6 +1402,16 @@ static SaveVMHandlers savevm_htab_handlers =3D { > .load_state =3D htab_load, > }; > =20 > +static void spapr_drc_reset(void *opaque) > +{ > + sPAPRDRConnector *drc =3D opaque; > + DeviceState *d =3D DEVICE(drc); > + > + if (d) { > + device_reset(d); > + } > +} > + > /* pSeries LPAR / sPAPR hardware init */ > static void ppc_spapr_init(MachineState *machine) > { > @@ -1418,6 +1437,7 @@ static void ppc_spapr_init(MachineState *machine) > long load_limit, fw_size; > bool kernel_le =3D false; > char *filename; > + int smt =3D kvmppc_smt_threads(); > =20 > msi_supported =3D true; > =20 > @@ -1564,6 +1584,15 @@ static void ppc_spapr_init(MachineState *machine) > spapr->dr_cpu_enabled =3D smc->dr_cpu_enabled; > spapr->dr_lmb_enabled =3D smc->dr_lmb_enabled; > =20 > + if (spapr->dr_cpu_enabled) { > + for (i =3D 0; i < max_cpus/smp_threads; i++) { > + sPAPRDRConnector *drc =3D > + spapr_dr_connector_new(OBJECT(machine), > + SPAPR_DR_CONNECTOR_TYPE_CPU, i * = smt); > + qemu_register_reset(spapr_drc_reset, drc); This seems to be per-core, rather than per-socket as your patch comments suggest. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --jsINjv9JwFjY+Quq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVEfwuAAoJEGw4ysog2bOSiowQAIlE8lrIog5tsXvgiAYzJkLK y6lGsghhK9GhaJe26dAqx0xWyiToghFl8xkaI9CCAOatvLnXljmgOpoAg4tHdEgU OlDsdio5toEylLg+1geWUY+Xa49mm1nBxaPXi0sRSB8hErucxO7Wv9Hqci3SyEgg h8EWy/NCDO0Ukxv+FamF4kBxTzPOER+1ehFHPkMkBQsB1zMpT2hzIyxNOlSMetwg brPMxa183KtI5GCAKIC54Mi8zjuWalYyaseyPOTeHmqT/XFW/DWzA7DfTCgXeejg eFfUDuLiv6WMax1R916/BLw9GsByewPIB8wYl6USeUN+ZPn812kaNhD1cPetzlGX 29ZmhsfJOyKupVPKo07vFnmVDrV1v0gBD01nx3U8S74mk/JdblZoLBD6DLAQZ38g WqfECD1BfFOZGFkH868ORMD94MHhQ0xPLsdNEUlArWleijBfQTJ3oehvUyOQEeDi 1w5T6I0gg6L4Z501PV5DOjmE9FQz9IPAJhaE7wcuwgNxtt9FAcJiBZMnp8jNrCj4 2R10mY3hvQs28q25XLcDtaNXN6FjB48nQfIpc9UMagwmBt2h6fOX0eG3bD8VjKuf oYRcHxpxAwlh8Myhh1vlOBsPKQNaXsdFrki25BTkxWA+lcEBuNRdMH6GSv0eSFAL Iu4Set7e130CKMDqZ7GA =tw07 -----END PGP SIGNATURE----- --jsINjv9JwFjY+Quq--