All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	pbonzini@redhat.com, qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] block: Switch to host monotonic clock for IO throttling
Date: Wed, 25 Mar 2015 08:16:23 +0100	[thread overview]
Message-ID: <20150325071623.GA19368@igalia.com> (raw)
In-Reply-To: <1427251352-14809-1-git-send-email-famz@redhat.com>

On Wed, Mar 25, 2015 at 10:42:32AM +0800, Fam Zheng wrote:

> Block jobs are confusingly inconsistent between with and without
> throttling: if user sets a bps limit, starts a block job, then stops
> vm, the block job will not make any progress; in contrary, if user
> unsets the bps limit, the block job will run normally.

Wait, that's not what happens:

a) If you start a job then stop the vm then the job will be
   completed immediately.
b) If you stop the vm then start the job then it won't make any
   progress.

This patch fixes b), but a) still happens.

Berto

  reply	other threads:[~2015-03-25  7:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25  2:42 [Qemu-devel] [PATCH v3] block: Switch to host monotonic clock for IO throttling Fam Zheng
2015-03-25  7:16 ` Alberto Garcia [this message]
2015-03-25  7:22   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150325071623.GA19368@igalia.com \
    --to=berto@igalia.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.