From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [patch v11 19/23] XEN / ACPI: Make XEN ACPI depend on X86 Date: Wed, 25 Mar 2015 11:51:13 +0000 Message-ID: <20150325115113.GF24636@arm.com> References: <1427205776-5060-1-git-send-email-hanjun.guo@linaro.org> <1427205776-5060-20-git-send-email-hanjun.guo@linaro.org> <55118303.8060003@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Stefano Stabellini Cc: Boris Ostrovsky , "hanjun.guo@linaro.org" , Catalin Marinas , "Rafael J. Wysocki" , Olof Johansson , "grant.likely@linaro.org" , Lorenzo Pieralisi , Arnd Bergmann , Mark Rutland , "graeme.gregory@linaro.org" , Sudeep Holla , "jcm@redhat.com" , Marc Zyngier , Mark Brown , Robert Richter , Timur Tabi , Ashwin Chaugule , "suravee.suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-acpi@vger.kernel.org" , linux-arm-kernel@l List-Id: linux-acpi@vger.kernel.org Hi Stefano, On Tue, Mar 24, 2015 at 05:24:53PM +0000, Stefano Stabellini wrote: > On Tue, 24 Mar 2015, Boris Ostrovsky wrote: > > On 03/24/2015 10:02 AM, Hanjun Guo wrote: > > > When ACPI is enabled on ARM64, XEN ACPI will also compiled > > > into the kernel, but XEN ACPI is x86 dependent, so introduce > > > CONFIG_XEN_ACPI to make it depend on x86 before XEN ACPI is > > > functional on ARM64. > > > > > > CC: 'Stefano Stabellini' > > > CC: Julien Grall > > > CC: Konrad Rzeszutek Wilk > > > CC: Boris Ostrovsky > > > CC: David Vrabel > > > Signed-off-by: Hanjun Guo > > > --- > > > drivers/xen/Kconfig | 4 ++++ > > > drivers/xen/Makefile | 2 +- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > > > index b812462..a31cd29 100644 > > > --- a/drivers/xen/Kconfig > > > +++ b/drivers/xen/Kconfig > > > @@ -253,4 +253,8 @@ config XEN_EFI > > > def_bool y > > > depends on X86_64 && EFI > > > +config XEN_ACPI > > > + def_bool y > > > + depends on X86 && ACPI > > > + > > > > > > I think XEN_DOM0 (in arch/x86/xen/Kconfig) should select this option. > > Otherwise, if it is set to 'n', we won't be able to build enlighten.c > > (xen_start_kernel() -> xen_acpi_sleep_register() refers to > > xen_acpi_notify_hypervisor_sleep()). > > > > I don't think that it is necessary: XEN_ACPI gets automatically enabled > anyway. In which case, can I have your Ack on this please? Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752809AbbCYLv0 (ORCPT ); Wed, 25 Mar 2015 07:51:26 -0400 Received: from foss.arm.com ([217.140.101.70]:50598 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423AbbCYLvU (ORCPT ); Wed, 25 Mar 2015 07:51:20 -0400 Date: Wed, 25 Mar 2015 11:51:13 +0000 From: Will Deacon To: Stefano Stabellini Cc: Boris Ostrovsky , "hanjun.guo@linaro.org" , Catalin Marinas , "Rafael J. Wysocki" , Olof Johansson , "grant.likely@linaro.org" , Lorenzo Pieralisi , Arnd Bergmann , Mark Rutland , "graeme.gregory@linaro.org" , Sudeep Holla , "jcm@redhat.com" , Marc Zyngier , Mark Brown , Robert Richter , Timur Tabi , Ashwin Chaugule , "suravee.suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , Julien Grall , Konrad Rzeszutek Wilk , David Vrabel Subject: Re: [patch v11 19/23] XEN / ACPI: Make XEN ACPI depend on X86 Message-ID: <20150325115113.GF24636@arm.com> References: <1427205776-5060-1-git-send-email-hanjun.guo@linaro.org> <1427205776-5060-20-git-send-email-hanjun.guo@linaro.org> <55118303.8060003@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefano, On Tue, Mar 24, 2015 at 05:24:53PM +0000, Stefano Stabellini wrote: > On Tue, 24 Mar 2015, Boris Ostrovsky wrote: > > On 03/24/2015 10:02 AM, Hanjun Guo wrote: > > > When ACPI is enabled on ARM64, XEN ACPI will also compiled > > > into the kernel, but XEN ACPI is x86 dependent, so introduce > > > CONFIG_XEN_ACPI to make it depend on x86 before XEN ACPI is > > > functional on ARM64. > > > > > > CC: 'Stefano Stabellini' > > > CC: Julien Grall > > > CC: Konrad Rzeszutek Wilk > > > CC: Boris Ostrovsky > > > CC: David Vrabel > > > Signed-off-by: Hanjun Guo > > > --- > > > drivers/xen/Kconfig | 4 ++++ > > > drivers/xen/Makefile | 2 +- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > > > index b812462..a31cd29 100644 > > > --- a/drivers/xen/Kconfig > > > +++ b/drivers/xen/Kconfig > > > @@ -253,4 +253,8 @@ config XEN_EFI > > > def_bool y > > > depends on X86_64 && EFI > > > +config XEN_ACPI > > > + def_bool y > > > + depends on X86 && ACPI > > > + > > > > > > I think XEN_DOM0 (in arch/x86/xen/Kconfig) should select this option. > > Otherwise, if it is set to 'n', we won't be able to build enlighten.c > > (xen_start_kernel() -> xen_acpi_sleep_register() refers to > > xen_acpi_notify_hypervisor_sleep()). > > > > I don't think that it is necessary: XEN_ACPI gets automatically enabled > anyway. In which case, can I have your Ack on this please? Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Wed, 25 Mar 2015 11:51:13 +0000 Subject: [patch v11 19/23] XEN / ACPI: Make XEN ACPI depend on X86 In-Reply-To: References: <1427205776-5060-1-git-send-email-hanjun.guo@linaro.org> <1427205776-5060-20-git-send-email-hanjun.guo@linaro.org> <55118303.8060003@oracle.com> Message-ID: <20150325115113.GF24636@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Stefano, On Tue, Mar 24, 2015 at 05:24:53PM +0000, Stefano Stabellini wrote: > On Tue, 24 Mar 2015, Boris Ostrovsky wrote: > > On 03/24/2015 10:02 AM, Hanjun Guo wrote: > > > When ACPI is enabled on ARM64, XEN ACPI will also compiled > > > into the kernel, but XEN ACPI is x86 dependent, so introduce > > > CONFIG_XEN_ACPI to make it depend on x86 before XEN ACPI is > > > functional on ARM64. > > > > > > CC: 'Stefano Stabellini' > > > CC: Julien Grall > > > CC: Konrad Rzeszutek Wilk > > > CC: Boris Ostrovsky > > > CC: David Vrabel > > > Signed-off-by: Hanjun Guo > > > --- > > > drivers/xen/Kconfig | 4 ++++ > > > drivers/xen/Makefile | 2 +- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > > > index b812462..a31cd29 100644 > > > --- a/drivers/xen/Kconfig > > > +++ b/drivers/xen/Kconfig > > > @@ -253,4 +253,8 @@ config XEN_EFI > > > def_bool y > > > depends on X86_64 && EFI > > > +config XEN_ACPI > > > + def_bool y > > > + depends on X86 && ACPI > > > + > > > > > > I think XEN_DOM0 (in arch/x86/xen/Kconfig) should select this option. > > Otherwise, if it is set to 'n', we won't be able to build enlighten.c > > (xen_start_kernel() -> xen_acpi_sleep_register() refers to > > xen_acpi_notify_hypervisor_sleep()). > > > > I don't think that it is necessary: XEN_ACPI gets automatically enabled > anyway. In which case, can I have your Ack on this please? Will