From: Marianne Moeller Knudsen <marianne@masu.dk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8192e: Replace printk with netdev_info
Date: Thu, 26 Mar 2015 02:33:22 +0100 [thread overview]
Message-ID: <20150326013322.GA3360@debianvm> (raw)
In-Reply-To: <20150323214302.GA24016@kroah.com>
On Mon, Mar 23, 2015 at 10:43:02PM +0100, Greg KH wrote:
> On Mon, Mar 23, 2015 at 07:04:24PM +0100, Marianne Moeller Knudsen wrote:
> > Replace printk(KERN_INFO...) by netdev_info for more uniform error
> > reporting. Issue found by checkpatch.
> >
> > Signed-off-by: Marianne Moeller Knudsen <marianne@masu.dk>
> > ---
> > drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > index c51f7e0..949cba4 100644
> > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > @@ -479,7 +479,7 @@ void RemovePeerTS(struct rtllib_device *ieee, u8 *Addr)
> >
> > list_for_each_entry_safe(pTS, pTmpTS, &ieee->Tx_TS_Admit_List, List) {
> > if (memcmp(pTS->Addr, Addr, 6) == 0) {
> > - printk(KERN_INFO "====>remove Tx_TS_admin_list\n");
> > + netdev_info(ieee->dev, "====>remove Tx_TS_admin_list\n");
> > RemoveTsEntry(ieee, pTS, TX_DIR);
> > list_del_init(&pTS->List);
> > list_add_tail(&pTS->List, &ieee->Tx_TS_Unused_List);
>
> Someone already sent this patch before you did :(
Out of curiosity: All the other prints in this file uses RTLLIB_DEBUG. Could it be assumed
that they could be used here as well? Something like RTLLIB_DEBUG(RLTLIB_DL_TS,
....)?
next prev parent reply other threads:[~2015-03-26 13:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 18:04 [PATCH] staging: rtl8192e: Replace printk with netdev_info Marianne Moeller Knudsen
2015-03-23 21:43 ` [Outreachy kernel] " Greg KH
2015-03-26 1:33 ` Marianne Moeller Knudsen [this message]
2015-03-26 13:27 ` Julia Lawall
2015-03-26 3:55 ` Marianne Moeller Knudsen
2015-03-26 19:10 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326013322.GA3360@debianvm \
--to=marianne@masu.dk \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.