From: Peter Hutterer <peter.hutterer@who-t.net>
To: Ping Cheng <pinglinux@gmail.com>
Cc: jkosina@suse.cz, linux-input@vger.kernel.org,
benjamin.tissoires@gmail.com, Ping Cheng <pingc@wacom.com>
Subject: Re: [PATCH 3/3] Add support for Cintiq 27QHD and 27QHD touch
Date: Thu, 26 Mar 2015 15:57:14 +1000 [thread overview]
Message-ID: <20150326055714.GA14141@jelly.bne.redhat.com> (raw)
In-Reply-To: <1422394203-15146-1-git-send-email-pingc@wacom.com>
On Tue, Jan 27, 2015 at 01:30:03PM -0800, Ping Cheng wrote:
> These devices have accelerometers. To report accelerometer coordinates,
> a new property, INPUT_PROP_ACCELEROMETER, is added.
>
> Signed-off-by: Ping Cheng <pingc@wacom.com>
> ---
[...]
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index a1d7e93..b0a8130 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -166,6 +166,7 @@ struct input_keymap_entry {
> #define INPUT_PROP_SEMI_MT 0x03 /* touch rectangle only */
> #define INPUT_PROP_TOPBUTTONPAD 0x04 /* softbuttons at top of pad */
> #define INPUT_PROP_POINTING_STICK 0x05 /* is a pointing stick */
> +#define INPUT_PROP_ACCELEROMETER 0x06 /* has accelerometer */
>
> #define INPUT_PROP_MAX 0x1f
> #define INPUT_PROP_CNT (INPUT_PROP_MAX + 1)
> --
> 1.9.1
I just ran into this and have a few questions:
what is the intended meaning of INPUT_PROP_ACCELEROMETER? For all the other
props it's obvious what they mean but here there it is a bit more ambiguous.
Specifically, if a device is tagged as accelerometer, which axes have
accelerometer data? just ABS_X/Y/Z and/or REL_X/Y/Z? or do we have a
requirement that _all_ axes on that device must reflect accelerometer data
(because realistically ABS_RX could be an accelerometer while x and y is a
normal axis). Or is it up for grabs and you need other information
to know which axes exported are accelerometers?
I know what it does on the 27QHD, but this is a generic tag so we need to
define this for all devices.
Cheers,
Peter
next prev parent reply other threads:[~2015-03-26 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 21:30 [PATCH 3/3] Add support for Cintiq 27QHD and 27QHD touch Ping Cheng
2015-03-26 5:57 ` Peter Hutterer [this message]
2015-03-26 18:47 ` Ping Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326055714.GA14141@jelly.bne.redhat.com \
--to=peter.hutterer@who-t.net \
--cc=benjamin.tissoires@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=pingc@wacom.com \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.