From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbbCZMMJ (ORCPT ); Thu, 26 Mar 2015 08:12:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45158 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbbCZMMH (ORCPT ); Thu, 26 Mar 2015 08:12:07 -0400 Date: Thu, 26 Mar 2015 13:12:03 +0100 From: Greg KH To: Niranjan Dighe Cc: liodot@gmail.com, charrer@alacritech.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: slicoss: Fix checkpatch.pl issues Message-ID: <20150326121203.GA22363@kroah.com> References: <1427227123-8570-1-git-send-email-niranjan.dighe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427227123-8570-1-git-send-email-niranjan.dighe@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2015 at 01:28:43AM +0530, Niranjan Dighe wrote: > Removed unused block of code guarded by #ifdef SLIC_TRACE_DUMP_ENABLED > And removed redundant static char *slic_banner and replaced actual string in > place of format string. That's multiple things you are doing all in the same patch, please break this up into multiple patches and resend. thanks, greg k-h