From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbbCZSgU (ORCPT ); Thu, 26 Mar 2015 14:36:20 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:42223 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752821AbbCZSdl (ORCPT ); Thu, 26 Mar 2015 14:33:41 -0400 Date: Thu, 26 Mar 2015 21:33:47 +0300 From: Dan Carpenter To: Niranjan Dighe Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, charrer@alacritech.com, liodot@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable Message-ID: <20150326183347.GY10964@mwanda> References: <20150326121203.GA22363@kroah.com> <1427394163-3074-1-git-send-email-niranjan.dighe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427394163-3074-1-git-send-email-niranjan.dighe@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote: > Replace string directly in place of format string and remove pointer > variable which was used just once. > > Signed-off-by: Niranjan Dighe > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c > index c2bda1d..f3110f7 100644 > --- a/drivers/staging/slicoss/slicoss.c > +++ b/drivers/staging/slicoss/slicoss.c > @@ -98,7 +98,6 @@ > #include "slic.h" > > static uint slic_first_init = 1; > -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)"; > > static char *slic_proc_version = "2.0.351 2006/07/14 12:26:00"; > > @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev, > return err; > > if (did_version++ == 0) { > - dev_info(&pcidev->dev, "%s\n", slic_banner); > + dev_info(&pcidev->dev, > + "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n"); This indenting looks ugly. regards, dan carpenter