From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752919AbbCZSzt (ORCPT ); Thu, 26 Mar 2015 14:55:49 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:33282 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbbCZSzp (ORCPT ); Thu, 26 Mar 2015 14:55:45 -0400 Date: Thu, 26 Mar 2015 19:55:37 +0100 From: Sascha Hauer To: Carlos Hernandez Cc: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, Stephen Warren , Mikko Perttunen , kernel@pengutronix.de, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Amit Daniel Kachhap Subject: Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures Message-ID: <20150326185537.GM9742@pengutronix.de> References: <1427385240-6086-1-git-send-email-s.hauer@pengutronix.de> <1427385240-6086-5-git-send-email-s.hauer@pengutronix.de> <55144C5B.7070208@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55144C5B.7070208@ti.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 19:48:11 up 10 days, 6:40, 48 users, load average: 0.03, 0.08, 0.09 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Cc Amit who implemented the emulation code. On Thu, Mar 26, 2015 at 02:13:47PM -0400, Carlos Hernandez wrote: > On 03/26/2015 11:53 AM, Sascha Hauer wrote: > >- The code should only accept an emulated temperature when the emulated > > temperature is lower than the critical temperature. Instead the code > > Why? > Emulating temperatures higher than critical temperature is useful > for testing. For instance it allows one to validate that critical > action (i.e. shutdown) is triggered. Not emulating critical temperatures was the intention of the original patch adding the emulation code, but it was implemented wrongly. I just fix to the intended behaviour. However, I also find emulating critical temperatures useful. I could also remove the check instead of fixing it if we can agree on that behaviour. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Thu, 26 Mar 2015 19:55:37 +0100 Subject: [PATCH 04/13] thermal: Fix not emulating critical temperatures In-Reply-To: <55144C5B.7070208@ti.com> References: <1427385240-6086-1-git-send-email-s.hauer@pengutronix.de> <1427385240-6086-5-git-send-email-s.hauer@pengutronix.de> <55144C5B.7070208@ti.com> Message-ID: <20150326185537.GM9742@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org +Cc Amit who implemented the emulation code. On Thu, Mar 26, 2015 at 02:13:47PM -0400, Carlos Hernandez wrote: > On 03/26/2015 11:53 AM, Sascha Hauer wrote: > >- The code should only accept an emulated temperature when the emulated > > temperature is lower than the critical temperature. Instead the code > > Why? > Emulating temperatures higher than critical temperature is useful > for testing. For instance it allows one to validate that critical > action (i.e. shutdown) is triggered. Not emulating critical temperatures was the intention of the original patch adding the emulation code, but it was implemented wrongly. I just fix to the intended behaviour. However, I also find emulating critical temperatures useful. I could also remove the check instead of fixing it if we can agree on that behaviour. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |