From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753376AbbC0BUK (ORCPT ); Thu, 26 Mar 2015 21:20:10 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:42015 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752632AbbC0BUG (ORCPT ); Thu, 26 Mar 2015 21:20:06 -0400 Date: Thu, 26 Mar 2015 18:19:14 -0700 From: Mark Brown To: yakir Cc: Liam Girdwood , djkurtz@chromium.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, David Airlie , Philipp Zabel , Russell King , Andy Yan , Greg Kroah-Hartman , Fabio Estevam , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , Brian Austin , Bard Liao , Oder Chiou , Max Filippov , Axel Lin , Arnd Bergmann , Jyri Sarha , Sean Cross , Ben Zhang , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, mmind00@googlemail.com, marcheu@chromium.org, mark.yao@rock-chips.com Message-ID: <20150327011914.GA1743@sirena.org.uk> References: <1425175834-24661-1-git-send-email-ykk@rock-chips.com> <1425179070-2736-1-git-send-email-ykk@rock-chips.com> <20150326181620.GZ3572@sirena.org.uk> <5514AF61.2050909@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline In-Reply-To: <5514AF61.2050909@rock-chips.com> X-Cookie: Professional driver on closed track. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 12.51.221.141 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 14/15] ASoC: rockchip/rockchip-hdmi-audio: add sound driver for hdmi audio X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 27, 2015 at 09:16:17AM +0800, yakir wrote: > On 2015=E5=B9=B403=E6=9C=8827=E6=97=A5 02:16, Mark Brown wrote: > >>+free_cpu_of_node: > >>+ hdmi_audio_dai.cpu_of_node =3D NULL; > >>+ hdmi_audio_dai.platform_of_node =3D NULL; > >>+free_priv_data: > >>+ snd_soc_card_set_drvdata(card, NULL); > >>+ platform_set_drvdata(pdev, NULL); > >>+ card->dev =3D NULL; > >If any of these assignments is doing anything there's a problem with the > >code. > Yes, when probe failed, program will goto this code. You're missing the point, these don't do anything useful. > >>+{ > >>+ struct snd_soc_card *card =3D platform_get_drvdata(pdev); > >>+ > >>+ snd_soc_unregister_card(card); > >devm_snd_soc_register_card() and you can remove this function entirely. > do you mean that when I take devm_snd_soc_register_card() to register car= d, > then I do not need unregister card any more(destroy with device) ? Yes, that is the whole point of the devm_ APIs. --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVFLAMAAoJECTWi3JdVIfQrikH/AgjFgaZRAKWgLL0td8JRqV7 j40bEsSqarnegkjO6wzGZnE2PqqkoGb3V6cCFey1z9YlY/5SytRTwYs/kQ3Fg8aU k5/7VmmFp7qE/fpTagPnlxr0f2Fpit2h7oBCIfBFYotiYBftFKfcBSOiIVkC22ML +iIwbWnM5GyWVghmMjvHjgNUlQC8gE5G73RwsRC1MkKV6Ob8G868e7IkRe+MjGv7 STElmVwoaRH/ScH1rB6aWRyJs4yd2ljXeiJ4XWdH4QYAvK/zryMC8ezlmXfESckg +VPZ0nzCnwt+0zZSJkPdYAjzKCEqsPN5fKyTtxXA7vhvgkTztDlM5BQ3OFe4Gwk= =6dCg -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v4 14/15] ASoC: rockchip/rockchip-hdmi-audio: add sound driver for hdmi audio Date: Thu, 26 Mar 2015 18:19:14 -0700 Message-ID: <20150327011914.GA1743@sirena.org.uk> References: <1425175834-24661-1-git-send-email-ykk@rock-chips.com> <1425179070-2736-1-git-send-email-ykk@rock-chips.com> <20150326181620.GZ3572@sirena.org.uk> <5514AF61.2050909@rock-chips.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4757691448138663492==" Return-path: In-Reply-To: <5514AF61.2050909-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: yakir Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, David Airlie , djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Max Filippov , Bard Liao , mmind00-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org, Lars-Peter Clausen , Axel Lin , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Takashi Iwai , Russell King , Sean Cross , Oder Chiou , Arnd Bergmann , Jyri Sarha , Ben Zhang , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Jaroslav Kysela , mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Fabio Estevam , Brian Austin , Greg Kroah-Hartman , Liam Girdwood , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Philipp Zabel List-Id: alsa-devel@alsa-project.org --===============4757691448138663492== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 27, 2015 at 09:16:17AM +0800, yakir wrote: > On 2015=E5=B9=B403=E6=9C=8827=E6=97=A5 02:16, Mark Brown wrote: > >>+free_cpu_of_node: > >>+ hdmi_audio_dai.cpu_of_node =3D NULL; > >>+ hdmi_audio_dai.platform_of_node =3D NULL; > >>+free_priv_data: > >>+ snd_soc_card_set_drvdata(card, NULL); > >>+ platform_set_drvdata(pdev, NULL); > >>+ card->dev =3D NULL; > >If any of these assignments is doing anything there's a problem with the > >code. > Yes, when probe failed, program will goto this code. You're missing the point, these don't do anything useful. > >>+{ > >>+ struct snd_soc_card *card =3D platform_get_drvdata(pdev); > >>+ > >>+ snd_soc_unregister_card(card); > >devm_snd_soc_register_card() and you can remove this function entirely. > do you mean that when I take devm_snd_soc_register_card() to register car= d, > then I do not need unregister card any more(destroy with device) ? Yes, that is the whole point of the devm_ APIs. --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVFLAMAAoJECTWi3JdVIfQrikH/AgjFgaZRAKWgLL0td8JRqV7 j40bEsSqarnegkjO6wzGZnE2PqqkoGb3V6cCFey1z9YlY/5SytRTwYs/kQ3Fg8aU k5/7VmmFp7qE/fpTagPnlxr0f2Fpit2h7oBCIfBFYotiYBftFKfcBSOiIVkC22ML +iIwbWnM5GyWVghmMjvHjgNUlQC8gE5G73RwsRC1MkKV6Ob8G868e7IkRe+MjGv7 STElmVwoaRH/ScH1rB6aWRyJs4yd2ljXeiJ4XWdH4QYAvK/zryMC8ezlmXfESckg +VPZ0nzCnwt+0zZSJkPdYAjzKCEqsPN5fKyTtxXA7vhvgkTztDlM5BQ3OFe4Gwk= =6dCg -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT-- --===============4757691448138663492== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============4757691448138663492==--