All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Chris Mason <clm@fb.com>,
	fdmanana@gmail.com, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: I think "btrfs: fix leak of path in btrfs_find_item" broke stable trees ...
Date: Fri, 27 Mar 2015 11:34:32 +0800	[thread overview]
Message-ID: <20150327033432.GB16812@dhcp-13-216.nay.redhat.com> (raw)
In-Reply-To: <55143DD7.2020608@redhat.com>

On Thu, Mar 26, 2015 at 12:11:51PM -0500, Eric Sandeen wrote:
> On 3/26/15 9:48 AM, Chris Mason wrote:
> > On Thu, Mar 26, 2015 at 10:11 AM, Eric Sandeen <sandeen@redhat.com> wrote:
> 
> ...
> 
> >>>>  9c4f61f btrfs: simplify insert_orphan_item
> >>>>
> >>>>  made the whole path alloc/free go away.
> >>
> >> so I think there's no need for my patch; may as well just send the above to stable
> >> and fix it that way, as long as 9c4f61f is deemed safe & correct, I think.
> > 
> > Nice catch, thanks Eric. 9c4f61f looks fine for stable to me, but
> > since he's already testing on stable, I talked Eric into giving it a
> > pass through xfstests before I send it up.
> > 
> > -chris
> 
> ./check -g auto on 3.19-stable-ish seems fine-ish.  Certainly no worse w/ the patch added :)
> 
> Failures: btrfs/010 btrfs/017 btrfs/078 generic/015 generic/039 generic/040 generic/041 generic/065 generic/066 generic/071 generic/204
> Failed 11 of 202 tests

Just FYI.

I think generic/204 is a test case issue, _filter_mkfs failed to print
isize and dbsize for btrfs and test failed because of divide by zero
error.

--- /dev/fd/63	2015-03-25 12:17:05.987107715 -0400
+++ results/generic/204.out.bad		      2015-03-25 12:17:05.423101244 -0400
@@ -1,2 +1,3 @@
 QA output created by 204
 +./tests/generic/204: line 76: space / (isize + dbsize): division by 0 (error token is ")")
  *** done

I'm working a patch for fstests.

Eryu

  parent reply	other threads:[~2015-03-27  3:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26  3:24 I think "btrfs: fix leak of path in btrfs_find_item" broke stable trees Eric Sandeen
2015-03-26 10:23 ` Filipe David Manana
2015-03-26 14:11   ` Eric Sandeen
2015-03-26 14:48     ` Chris Mason
2015-03-26 17:11       ` Eric Sandeen
2015-03-26 17:25         ` Filipe David Manana
2015-03-26 20:38           ` Eric Sandeen
2015-03-27  3:34         ` Eryu Guan [this message]
2015-03-27 21:49           ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150327033432.GB16812@dhcp-13-216.nay.redhat.com \
    --to=guaneryu@gmail.com \
    --cc=clm@fb.com \
    --cc=fdmanana@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.