From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH v3 4/4] libxl: add support for vscsi Date: Fri, 27 Mar 2015 08:38:34 +0100 Message-ID: <20150327073834.GA12756@aepfle.de> References: <1425635156-2357-1-git-send-email-olaf@aepfle.de> <1425635156-2357-5-git-send-email-olaf@aepfle.de> <1426088006.21353.282.camel@citrix.com> <20150312162031.GB19536@aepfle.de> <1426178782.32572.55.camel@citrix.com> <20150313134420.GC25259@aepfle.de> <1426256282.32572.154.camel@citrix.com> <20150326125548.GA21507@aepfle.de> <1427377615.13935.59.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1427377615.13935.59.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Wei Liu , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, Mar 26, Ian Campbell wrote: > On Thu, 2015-03-26 at 13:55 +0100, Olaf Hering wrote: > > On Fri, Mar 13, Ian Campbell wrote: > > > Also, should this be a defbool or not? > > This is a good idea. I remmeber xend had code to make sure that all > > devices within a vhost had the same value for "feature-host". I think > > the intention was that whole physical hosts are passed to a domU. A > > defbool makes it easier to preserve the initial value based on the first > > config item. > > In which case it sounds to me like this flag should be at a per-vhost > level and not at a per device level. Its per vhost already, "libxl_device_vscsi" refers to the virtual scsi host, and "libxl_vscsi_dev" refers to a device connected to that host. Perhaps the latter needs a better name to make the difference more obvious. Olaf