From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753845AbbC0JVs (ORCPT ); Fri, 27 Mar 2015 05:21:48 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:42003 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061AbbC0JVq (ORCPT ); Fri, 27 Mar 2015 05:21:46 -0400 Date: Fri, 27 Mar 2015 10:21:44 +0100 From: Sascha Hauer To: Stephen Boyd Cc: Mike Turquette , YH Chen , linux-kernel@vger.kernel.org, Henry Chen , linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Matthias Brugger , Yingjoe Chen , Eddie Huang , linux-arm-kernel@lists.infradead.org, James Liao Subject: Re: [PATCH 4/6] clk: mediatek: Add basic clocks for Mediatek MT8135. Message-ID: <20150327092144.GW9742@pengutronix.de> References: <1426754530-3137-1-git-send-email-s.hauer@pengutronix.de> <1426754530-3137-5-git-send-email-s.hauer@pengutronix.de> <20150327073950.GF18059@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150327073950.GF18059@codeaurora.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:20:31 up 10 days, 21:12, 43 users, load average: 0.15, 0.16, 0.21 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2015 at 12:39:50AM -0700, Stephen Boyd wrote: > On 03/19, Sascha Hauer wrote: > > diff --git a/drivers/clk/mediatek/clk-mt8135.c b/drivers/clk/mediatek/clk-mt8135.c > > new file mode 100644 > > index 0000000..a22f6fa > > --- /dev/null > > +++ b/drivers/clk/mediatek/clk-mt8135.c > > @@ -0,0 +1,640 @@ > > +/* > > + * Copyright (c) 2014 MediaTek Inc. > > + * Author: James Liao > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "clk-mtk.h" > > +#include "clk-gate.h" > > + > > +static DEFINE_SPINLOCK(lock); > > Nitpick: 'lock' is very generic. Lockdep will use the variable > name in its output, so it's wise to make locks have better names > if possible. How about mt8135_lock? I just renamed this to mt8135_clk_lock/mt8173_clk_lock and resent the series. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Fri, 27 Mar 2015 10:21:44 +0100 Subject: [PATCH 4/6] clk: mediatek: Add basic clocks for Mediatek MT8135. In-Reply-To: <20150327073950.GF18059@codeaurora.org> References: <1426754530-3137-1-git-send-email-s.hauer@pengutronix.de> <1426754530-3137-5-git-send-email-s.hauer@pengutronix.de> <20150327073950.GF18059@codeaurora.org> Message-ID: <20150327092144.GW9742@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Mar 27, 2015 at 12:39:50AM -0700, Stephen Boyd wrote: > On 03/19, Sascha Hauer wrote: > > diff --git a/drivers/clk/mediatek/clk-mt8135.c b/drivers/clk/mediatek/clk-mt8135.c > > new file mode 100644 > > index 0000000..a22f6fa > > --- /dev/null > > +++ b/drivers/clk/mediatek/clk-mt8135.c > > @@ -0,0 +1,640 @@ > > +/* > > + * Copyright (c) 2014 MediaTek Inc. > > + * Author: James Liao > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "clk-mtk.h" > > +#include "clk-gate.h" > > + > > +static DEFINE_SPINLOCK(lock); > > Nitpick: 'lock' is very generic. Lockdep will use the variable > name in its output, so it's wise to make locks have better names > if possible. How about mt8135_lock? I just renamed this to mt8135_clk_lock/mt8173_clk_lock and resent the series. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |