From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Lionel Landwerlin <lionel.g.landwerlin@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4] drm/i915: Implement inter-engine read-read optimisations
Date: Fri, 27 Mar 2015 11:38:53 +0000 [thread overview]
Message-ID: <20150327113853.GA28765@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <55153D67.6070501@linux.intel.com>
On Fri, Mar 27, 2015 at 11:22:15AM +0000, Tvrtko Ursulin wrote:
> On 03/26/2015 09:31 PM, Chris Wilson wrote:
> >I want to replace the (| 1) with
> >(| intel_ring_flag(obj->last_write_request->ring); but it exists because
> >we couldn't be sure if any userspace depended on exactly (0, 1).
>
> I don't get it, it is exported to userspace and now it is different,
> why is that OK?
The ABI is that the upper 16bits indicate the active rings. That is what
userspace requires. We set the low bit to indicate busy because we were
afraid of confusing older userspace, but that was unfounded if we check
the history of all users, so we can safely repurpose the low 16bits to
be active write ring.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-03-27 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 15:45 [PATCH] drm/i915: Implement inter-engine read-read optimisations Chris Wilson
2015-03-17 9:54 ` [PATCH v2] " Chris Wilson
2015-03-17 10:11 ` [PATCH v3] " Chris Wilson
2015-03-19 8:59 ` [PATCH v4] " Chris Wilson
2015-03-26 16:09 ` Lionel Landwerlin
2015-03-26 16:09 ` [PATCH] drm/i915: Implement " Lionel Landwerlin
2015-03-26 16:12 ` Chris Wilson
2015-03-26 17:43 ` [PATCH v4] drm/i915: Implement " Tvrtko Ursulin
2015-03-26 21:31 ` Chris Wilson
2015-03-27 11:22 ` Tvrtko Ursulin
2015-03-27 11:38 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327113853.GA28765@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@linux.intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.