From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC PATCH 09/11] IB/Verbs: Use management helper has_ipoib() and, cap_ipoib() for ipoib-check Date: Fri, 27 Mar 2015 10:06:16 -0600 Message-ID: <20150327160616.GA28412@obsidianresearch.com> References: <551579CA.4030901@profitbricks.com> <55157BC6.70400@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <55157BC6.70400@profitbricks.com> Sender: linux-kernel-owner@vger.kernel.org To: Michael Wang Cc: Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin List-Id: linux-rdma@vger.kernel.org On Fri, Mar 27, 2015 at 04:48:22PM +0100, Michael Wang wrote: > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c > index 3341754..fcd7558 100644 > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c > @@ -1655,7 +1655,7 @@ static void ipoib_add_one(struct ib_device *device) > struct ipoib_dev_priv *priv; > int s, e, p; > > - if (!rdma_transport_is_ib(device)) > + if (!has_ipoib(device)) > return; This is a good example of a test that doesn't really make sense, IPoIB is certainly a port specific attribute. > dev_list = kmalloc(sizeof *dev_list, GFP_KERNEL); > @@ -1673,7 +1673,7 @@ static void ipoib_add_one(struct ib_device *device) > } > > for (p = s; p <= e; ++p) { > - if (!rdma_port_ll_is_ib(device, p)) > + if (!cap_ipoib(device, p)) > continue; And down here we test every port. The routine should just test every port and do nothing if no ports need IPoIB. > dev = ipoib_add_port("ib%d", device, p); > if (!IS_ERR(dev)) { > @@ -1690,7 +1690,7 @@ static void ipoib_remove_one(struct ib_device *device) > struct ipoib_dev_priv *priv, *tmp; > struct list_head *dev_list; > > - if (!rdma_transport_is_ib(device)) > + if (!has_ipoib(device)) > return; This test should be made redundant by having ib_get_client_data return null if ipoib_add_one didn't do anything. Maybe that already happens? Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753406AbbC0QG0 (ORCPT ); Fri, 27 Mar 2015 12:06:26 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:50938 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581AbbC0QGY (ORCPT ); Fri, 27 Mar 2015 12:06:24 -0400 Date: Fri, 27 Mar 2015 10:06:16 -0600 From: Jason Gunthorpe To: Michael Wang Cc: Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin , Doug Ledford , Eric Dumazet , Erez Shitrit , Sagi Grimberg , Haggai Eran , Shachar Raindel , Mike Marciniszyn , Steve Wise , Tom Tucker , Chuck Lever Subject: Re: [RFC PATCH 09/11] IB/Verbs: Use management helper has_ipoib() and, cap_ipoib() for ipoib-check Message-ID: <20150327160616.GA28412@obsidianresearch.com> References: <551579CA.4030901@profitbricks.com> <55157BC6.70400@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55157BC6.70400@profitbricks.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.183 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2015 at 04:48:22PM +0100, Michael Wang wrote: > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c > index 3341754..fcd7558 100644 > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c > @@ -1655,7 +1655,7 @@ static void ipoib_add_one(struct ib_device *device) > struct ipoib_dev_priv *priv; > int s, e, p; > > - if (!rdma_transport_is_ib(device)) > + if (!has_ipoib(device)) > return; This is a good example of a test that doesn't really make sense, IPoIB is certainly a port specific attribute. > dev_list = kmalloc(sizeof *dev_list, GFP_KERNEL); > @@ -1673,7 +1673,7 @@ static void ipoib_add_one(struct ib_device *device) > } > > for (p = s; p <= e; ++p) { > - if (!rdma_port_ll_is_ib(device, p)) > + if (!cap_ipoib(device, p)) > continue; And down here we test every port. The routine should just test every port and do nothing if no ports need IPoIB. > dev = ipoib_add_port("ib%d", device, p); > if (!IS_ERR(dev)) { > @@ -1690,7 +1690,7 @@ static void ipoib_remove_one(struct ib_device *device) > struct ipoib_dev_priv *priv, *tmp; > struct list_head *dev_list; > > - if (!rdma_transport_is_ib(device)) > + if (!has_ipoib(device)) > return; This test should be made redundant by having ib_get_client_data return null if ipoib_add_one didn't do anything. Maybe that already happens? Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC PATCH 09/11] IB/Verbs: Use management helper has_ipoib() and, cap_ipoib() for ipoib-check Date: Fri, 27 Mar 2015 10:06:16 -0600 Message-ID: <20150327160616.GA28412@obsidianresearch.com> References: <551579CA.4030901@profitbricks.com> <55157BC6.70400@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin Return-path: Content-Disposition: inline In-Reply-To: <55157BC6.70400@profitbricks.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Mar 27, 2015 at 04:48:22PM +0100, Michael Wang wrote: > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c > index 3341754..fcd7558 100644 > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c > @@ -1655,7 +1655,7 @@ static void ipoib_add_one(struct ib_device *device) > struct ipoib_dev_priv *priv; > int s, e, p; > > - if (!rdma_transport_is_ib(device)) > + if (!has_ipoib(device)) > return; This is a good example of a test that doesn't really make sense, IPoIB is certainly a port specific attribute. > dev_list = kmalloc(sizeof *dev_list, GFP_KERNEL); > @@ -1673,7 +1673,7 @@ static void ipoib_add_one(struct ib_device *device) > } > > for (p = s; p <= e; ++p) { > - if (!rdma_port_ll_is_ib(device, p)) > + if (!cap_ipoib(device, p)) > continue; And down here we test every port. The routine should just test every port and do nothing if no ports need IPoIB. > dev = ipoib_add_port("ib%d", device, p); > if (!IS_ERR(dev)) { > @@ -1690,7 +1690,7 @@ static void ipoib_remove_one(struct ib_device *device) > struct ipoib_dev_priv *priv, *tmp; > struct list_head *dev_list; > > - if (!rdma_transport_is_ib(device)) > + if (!has_ipoib(device)) > return; This test should be made redundant by having ib_get_client_data return null if ipoib_add_one didn't do anything. Maybe that already happens? Jason