From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC PATCH 09/11] IB/Verbs: Use management helper has_ipoib() and, cap_ipoib() for ipoib-check Date: Fri, 27 Mar 2015 10:38:57 -0600 Message-ID: <20150327163857.GE28412@obsidianresearch.com> References: <551579CA.4030901@profitbricks.com> <55157BC6.70400@profitbricks.com> <20150327160616.GA28412@obsidianresearch.com> <5515822E.2020207@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5515822E.2020207@profitbricks.com> Sender: linux-kernel-owner@vger.kernel.org To: Michael Wang Cc: Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin List-Id: linux-rdma@vger.kernel.org On Fri, Mar 27, 2015 at 05:15:42PM +0100, Michael Wang wrote: > I'm not sure if it's a good idea, but seems like the idea is use twice > check on different level to save some cycles? That is what it looks like to me, right now. Which is why I'd drop it. This isn't performance sensitive, make it simple. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753528AbbC0QjO (ORCPT ); Fri, 27 Mar 2015 12:39:14 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:57405 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753181AbbC0QjJ (ORCPT ); Fri, 27 Mar 2015 12:39:09 -0400 Date: Fri, 27 Mar 2015 10:38:57 -0600 From: Jason Gunthorpe To: Michael Wang Cc: Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin , Doug Ledford , Eric Dumazet , Erez Shitrit , Sagi Grimberg , Haggai Eran , Shachar Raindel , Mike Marciniszyn , Steve Wise , Tom Tucker , Chuck Lever Subject: Re: [RFC PATCH 09/11] IB/Verbs: Use management helper has_ipoib() and, cap_ipoib() for ipoib-check Message-ID: <20150327163857.GE28412@obsidianresearch.com> References: <551579CA.4030901@profitbricks.com> <55157BC6.70400@profitbricks.com> <20150327160616.GA28412@obsidianresearch.com> <5515822E.2020207@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5515822E.2020207@profitbricks.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.183 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2015 at 05:15:42PM +0100, Michael Wang wrote: > I'm not sure if it's a good idea, but seems like the idea is use twice > check on different level to save some cycles? That is what it looks like to me, right now. Which is why I'd drop it. This isn't performance sensitive, make it simple. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC PATCH 09/11] IB/Verbs: Use management helper has_ipoib() and, cap_ipoib() for ipoib-check Date: Fri, 27 Mar 2015 10:38:57 -0600 Message-ID: <20150327163857.GE28412@obsidianresearch.com> References: <551579CA.4030901@profitbricks.com> <55157BC6.70400@profitbricks.com> <20150327160616.GA28412@obsidianresearch.com> <5515822E.2020207@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin Return-path: Content-Disposition: inline In-Reply-To: <5515822E.2020207@profitbricks.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Mar 27, 2015 at 05:15:42PM +0100, Michael Wang wrote: > I'm not sure if it's a good idea, but seems like the idea is use twice > check on different level to save some cycles? That is what it looks like to me, right now. Which is why I'd drop it. This isn't performance sensitive, make it simple. Jason