From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ira.weiny" Subject: Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check Date: Fri, 27 Mar 2015 13:16:31 -0400 Message-ID: <20150327171631.GC27862@phlsvsds.ph.intel.com> References: <551579CA.4030901@profitbricks.com> <55157B98.1060103@profitbricks.com> <20150327161319.GB28412@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150327161319.GB28412@obsidianresearch.com> Sender: linux-kernel-owner@vger.kernel.org To: Jason Gunthorpe Cc: Michael Wang , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin List-Id: linux-rdma@vger.kernel.org On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: > > > > Introduce helper has_iwarp() to help us check if an IB device > > support IWARP protocol. > > Should probably be !has_rdma_read_sges() > > True if the device can handle more than one SGE entry on a RDMA READ > work request. Isn't this value already provided by the query_device verb? The verbs spec states the Query HCA contains the: "Maximum number of scatter/gather entries per Work Request supported by the HCA." -- Ira > > Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030279AbbC0RQv (ORCPT ); Fri, 27 Mar 2015 13:16:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:59767 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbbC0RQn (ORCPT ); Fri, 27 Mar 2015 13:16:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,479,1422950400"; d="scan'208";a="473600066" Date: Fri, 27 Mar 2015 13:16:31 -0400 From: "ira.weiny" To: Jason Gunthorpe Cc: Michael Wang , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin , Doug Ledford , Eric Dumazet , Erez Shitrit , Sagi Grimberg , Haggai Eran , Shachar Raindel , Mike Marciniszyn , Steve Wise , Tom Tucker , Chuck Lever Subject: Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check Message-ID: <20150327171631.GC27862@phlsvsds.ph.intel.com> References: <551579CA.4030901@profitbricks.com> <55157B98.1060103@profitbricks.com> <20150327161319.GB28412@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150327161319.GB28412@obsidianresearch.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: > > > > Introduce helper has_iwarp() to help us check if an IB device > > support IWARP protocol. > > Should probably be !has_rdma_read_sges() > > True if the device can handle more than one SGE entry on a RDMA READ > work request. Isn't this value already provided by the query_device verb? The verbs spec states the Query HCA contains the: "Maximum number of scatter/gather entries per Work Request supported by the HCA." -- Ira > > Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ira.weiny" Subject: Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check Date: Fri, 27 Mar 2015 13:16:31 -0400 Message-ID: <20150327171631.GC27862@phlsvsds.ph.intel.com> References: <551579CA.4030901@profitbricks.com> <55157B98.1060103@profitbricks.com> <20150327161319.GB28412@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Michael Wang , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "J. Bruce Fields" , Trond Myklebust , "David S. Miller" , Or Gerlitz , Moni Shoua , PJ Waskiewicz , Tatyana Nikolova , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Majd Dibbiny , Jiri Kosina , Matan Barak , Alex Estrin Return-path: Content-Disposition: inline In-Reply-To: <20150327161319.GB28412@obsidianresearch.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: > > > > Introduce helper has_iwarp() to help us check if an IB device > > support IWARP protocol. > > Should probably be !has_rdma_read_sges() > > True if the device can handle more than one SGE entry on a RDMA READ > work request. Isn't this value already provided by the query_device verb? The verbs spec states the Query HCA contains the: "Maximum number of scatter/gather entries per Work Request supported by the HCA." -- Ira > > Jason