From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753310AbbC0Ugw (ORCPT ); Fri, 27 Mar 2015 16:36:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58922 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752976AbbC0Ugu (ORCPT ); Fri, 27 Mar 2015 16:36:50 -0400 Date: Fri, 27 Mar 2015 21:36:46 +0100 From: "Luis R. Rodriguez" To: Hyong-Youb Kim Cc: "Luis R. Rodriguez" , luto@amacapital.net, mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, jgross@suse.com, JBeulich@suse.com, bp@suse.de, suresh.b.siddha@intel.com, venkatesh.pallipadi@intel.com, airlied@redhat.com, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org, Ingo Molnar , Daniel Vetter , Hyong-Youb Kim , netdev@vger.kernel.org, Antonino Daplas , Jean-Christophe Plagniol-Villard , Tomi Valkeinen Subject: Re: [PATCH v1 21/47] ethernet: myri10ge: use arch_phys_wc_add() Message-ID: <20150327203646.GN5622@wotan.suse.de> References: <1426893517-2511-1-git-send-email-mcgrof@do-not-panic.com> <1426893517-2511-22-git-send-email-mcgrof@do-not-panic.com> <20150321070759.GB8766@gtest01.arcus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150321070759.GB8766@gtest01.arcus> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 21, 2015 at 04:08:00PM +0900, Hyong-Youb Kim wrote: > On Fri, Mar 20, 2015 at 04:18:11PM -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > This driver already uses ioremap_wc() on the same range > > so when write-combining is available that will be used > > instead. > > > [...] > > --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > > +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > [...] > > @@ -1984,7 +1979,6 @@ myri10ge_get_ethtool_stats(struct net_device *netdev, > > data[i] = ((u64 *)&link_stats)[i]; > > > > data[i++] = (unsigned int)mgp->tx_boundary; > > - data[i++] = (unsigned int)mgp->wc_enabled; > > data[i++] = (unsigned int)mgp->pdev->irq; > > data[i++] = (unsigned int)mgp->msi_enabled; > > data[i++] = (unsigned int)mgp->msix_enabled; > > You would have to delete "WC from myri10ge_gstrings_main_stats too. > Something like below. Thanks. > > @@ -1905,7 +1905,7 @@ static const char myri10ge_gstrings_main_stats[][ETH_GSTRING_LEN] = { > "tx_aborted_errors", "tx_carrier_errors", "tx_fifo_errors", > "tx_heartbeat_errors", "tx_window_errors", > /* device-specific stats */ > - "tx_boundary", "WC", "irq", "MSI", "MSIX", > + "tx_boundary", "irq", "MSI", "MSIX", > "read_dma_bw_MBs", "write_dma_bw_MBs", "read_write_dma_bw_MBs", > "serial_number", "watchdog_resets", > #ifdef CONFIG_MYRI10GE_DCA OK great thanks. Amended. Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Date: Fri, 27 Mar 2015 20:36:46 +0000 Subject: Re: [PATCH v1 21/47] ethernet: myri10ge: use arch_phys_wc_add() Message-Id: <20150327203646.GN5622@wotan.suse.de> List-Id: References: <1426893517-2511-1-git-send-email-mcgrof@do-not-panic.com> <1426893517-2511-22-git-send-email-mcgrof@do-not-panic.com> <20150321070759.GB8766@gtest01.arcus> In-Reply-To: <20150321070759.GB8766@gtest01.arcus> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hyong-Youb Kim Cc: "Luis R. Rodriguez" , luto@amacapital.net, mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, jgross@suse.com, JBeulich@suse.com, bp@suse.de, suresh.b.siddha@intel.com, venkatesh.pallipadi@intel.com, airlied@redhat.com, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org, Ingo Molnar , Daniel Vetter , Hyong-Youb Kim , netdev@vger.kernel.org, Antonino Daplas , Jean-Christophe Plagniol-Villard , Tomi Valkeinen On Sat, Mar 21, 2015 at 04:08:00PM +0900, Hyong-Youb Kim wrote: > On Fri, Mar 20, 2015 at 04:18:11PM -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > This driver already uses ioremap_wc() on the same range > > so when write-combining is available that will be used > > instead. > > > [...] > > --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > > +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > [...] > > @@ -1984,7 +1979,6 @@ myri10ge_get_ethtool_stats(struct net_device *netdev, > > data[i] = ((u64 *)&link_stats)[i]; > > > > data[i++] = (unsigned int)mgp->tx_boundary; > > - data[i++] = (unsigned int)mgp->wc_enabled; > > data[i++] = (unsigned int)mgp->pdev->irq; > > data[i++] = (unsigned int)mgp->msi_enabled; > > data[i++] = (unsigned int)mgp->msix_enabled; > > You would have to delete "WC from myri10ge_gstrings_main_stats too. > Something like below. Thanks. > > @@ -1905,7 +1905,7 @@ static const char myri10ge_gstrings_main_stats[][ETH_GSTRING_LEN] = { > "tx_aborted_errors", "tx_carrier_errors", "tx_fifo_errors", > "tx_heartbeat_errors", "tx_window_errors", > /* device-specific stats */ > - "tx_boundary", "WC", "irq", "MSI", "MSIX", > + "tx_boundary", "irq", "MSI", "MSIX", > "read_dma_bw_MBs", "write_dma_bw_MBs", "read_write_dma_bw_MBs", > "serial_number", "watchdog_resets", > #ifdef CONFIG_MYRI10GE_DCA OK great thanks. Amended. Luis