All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Bob Liu <bob.liu@oracle.com>,
	xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
	jennifer.herbert@citrix.com, david.vrabel@citrix.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()
Date: Fri, 27 Mar 2015 20:44:59 -0400	[thread overview]
Message-ID: <20150328004459.GA14373@l.oracle.com> (raw)
In-Reply-To: <5514269D.6050905@citrix.com>

On Thu, Mar 26, 2015 at 04:32:45PM +0100, Roger Pau Monné wrote:
> El 26/03/15 a les 13.16, Bob Liu ha escrit:
> > There are several place using gnttab async unmap and wait for
> > completion, so move the common code to a function
> > gnttab_unmap_refs_async_wait_completion().
> > 
> > Signed-off-by: Bob Liu <bob.liu@oracle.com>
> 
> For the blkback parts:
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Although, as David already said, I think we should do better than BUG_ON
> on error.

Have an 'stuck deferred pages' list and an timer to occasionally
flush them out? Something similar to 569ca5b3f94cd0b3295ec5943aa457cf4a4f6a3a
"xen/gnttab: add deferred freeing logic" ?
> 

  parent reply	other threads:[~2015-03-28  0:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 12:16 [PATCH RESEND 1/2] xen/blkback: safely unmap purge persistent grants Bob Liu
2015-03-26 12:16 ` [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion() Bob Liu
2015-03-26 12:16 ` Bob Liu
2015-03-26 15:32   ` Roger Pau Monné
2015-03-28  0:44     ` Konrad Rzeszutek Wilk
2015-03-28  0:44     ` Konrad Rzeszutek Wilk [this message]
2015-03-30  0:03       ` Bob Liu
2015-03-30  0:03       ` Bob Liu
2015-04-01 10:05         ` David Vrabel
2015-04-01 10:05         ` [Xen-devel] " David Vrabel
2015-03-26 15:32   ` Roger Pau Monné
2015-03-26 19:01   ` Konrad Rzeszutek Wilk
2015-03-26 19:01   ` Konrad Rzeszutek Wilk
2015-04-01 10:18   ` David Vrabel
2015-04-01 10:18   ` [Xen-devel] " David Vrabel
2015-04-01 11:55     ` Bob Liu
2015-04-01 11:55     ` [Xen-devel] " Bob Liu
2015-03-26 15:23 ` [PATCH RESEND 1/2] xen/blkback: safely unmap purge persistent grants Roger Pau Monné
2015-03-26 15:23 ` Roger Pau Monné
2015-03-26 19:01   ` Konrad Rzeszutek Wilk
2015-03-26 19:01   ` Konrad Rzeszutek Wilk
2015-03-26 20:11     ` Jens Axboe
2015-03-26 20:11     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150328004459.GA14373@l.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=bob.liu@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=jennifer.herbert@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.