From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751968AbbC1ITN (ORCPT ); Sat, 28 Mar 2015 04:19:13 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:57326 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbbC1ITJ (ORCPT ); Sat, 28 Mar 2015 04:19:09 -0400 Date: Sat, 28 Mar 2015 09:18:43 +0100 From: Sam Ravnborg To: Yinghai Lu Cc: David Ahern , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "sparclinux@vger.kernel.org" , LKML Subject: Re: d63e2e1f3df breaks sparc/T5-8 Message-ID: <20150328081843.GA27114@ravnborg.org> References: <5514391F.2030300@oracle.com> <551495EE.20201@oracle.com> <20150328010532.GA15897@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> config ARM_THUMB > >> bool "Support Thumb user binaries" if !CPU_THUMBONLY > >> depends on CPU_ARM720T || CPU_ARM740T || CPU_ARM920T || CPU_ARM922T || \ > >> Index: linux-2.6/arch/arm64/Kconfig > >> =================================================================== > >> --- linux-2.6.orig/arch/arm64/Kconfig > >> +++ linux-2.6/arch/arm64/Kconfig > >> @@ -125,6 +125,9 @@ config HAVE_GENERIC_RCU_GUP > >> config ARCH_DMA_ADDR_T_64BIT > >> def_bool y > >> > >> +config ARCH_PCI_BUS_ADDR_T_64BIT > >> + def_bool y > >> + > > Use select > ... > > I was trying to keep the style to be consistent with old one in each Kconfig. > > So do we just need to make sure new added lines to use new style? Use new style select everywhere. That could maybe in the future trigger someone to update the different arch configs to use select for the remaining bits. > >> Index: linux-2.6/include/linux/types.h > >> =================================================================== > >> --- linux-2.6.orig/include/linux/types.h > >> +++ linux-2.6/include/linux/types.h > >> @@ -146,6 +146,13 @@ typedef u64 dma_addr_t; > >> typedef u32 dma_addr_t; > >> #endif /* dma_addr_t */ > >> > >> +/* A pci_bus_addr_t can hold pci bus address for the platform */ > >> +#ifdef CONFIG_ARCH_PCI_BUS_ADDR_T_64BIT > >> +typedef u64 pci_bus_addr_t; > >> +#else > >> +typedef u32 pci_bus_addr_t; > >> +#endif /* pci_bus_addr_t */ > >> + > > Looking att all the Kconfig logic I get the impression that > > the type of pci_bus_addr_t equals unsigned long. > > If this is correct then you can skip that and things > > gets much simpler. > > For x86 32bit with PAE support, we could use 64bit for bus address. > but unsigned long is 32bit. Missed that part - OK. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Sat, 28 Mar 2015 08:18:43 +0000 Subject: Re: d63e2e1f3df breaks sparc/T5-8 Message-Id: <20150328081843.GA27114@ravnborg.org> List-Id: References: <5514391F.2030300@oracle.com> <551495EE.20201@oracle.com> <20150328010532.GA15897@ravnborg.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yinghai Lu Cc: David Ahern , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "sparclinux@vger.kernel.org" , LKML > >> config ARM_THUMB > >> bool "Support Thumb user binaries" if !CPU_THUMBONLY > >> depends on CPU_ARM720T || CPU_ARM740T || CPU_ARM920T || CPU_ARM922T || \ > >> Index: linux-2.6/arch/arm64/Kconfig > >> =================================> >> --- linux-2.6.orig/arch/arm64/Kconfig > >> +++ linux-2.6/arch/arm64/Kconfig > >> @@ -125,6 +125,9 @@ config HAVE_GENERIC_RCU_GUP > >> config ARCH_DMA_ADDR_T_64BIT > >> def_bool y > >> > >> +config ARCH_PCI_BUS_ADDR_T_64BIT > >> + def_bool y > >> + > > Use select > ... > > I was trying to keep the style to be consistent with old one in each Kconfig. > > So do we just need to make sure new added lines to use new style? Use new style select everywhere. That could maybe in the future trigger someone to update the different arch configs to use select for the remaining bits. > >> Index: linux-2.6/include/linux/types.h > >> =================================> >> --- linux-2.6.orig/include/linux/types.h > >> +++ linux-2.6/include/linux/types.h > >> @@ -146,6 +146,13 @@ typedef u64 dma_addr_t; > >> typedef u32 dma_addr_t; > >> #endif /* dma_addr_t */ > >> > >> +/* A pci_bus_addr_t can hold pci bus address for the platform */ > >> +#ifdef CONFIG_ARCH_PCI_BUS_ADDR_T_64BIT > >> +typedef u64 pci_bus_addr_t; > >> +#else > >> +typedef u32 pci_bus_addr_t; > >> +#endif /* pci_bus_addr_t */ > >> + > > Looking att all the Kconfig logic I get the impression that > > the type of pci_bus_addr_t equals unsigned long. > > If this is correct then you can skip that and things > > gets much simpler. > > For x86 32bit with PAE support, we could use 64bit for bus address. > but unsigned long is 32bit. Missed that part - OK. Sam