From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753536AbbC2OBT (ORCPT ); Sun, 29 Mar 2015 10:01:19 -0400 Received: from mail.skyhub.de ([78.46.96.112]:60244 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753372AbbC2OBQ (ORCPT ); Sun, 29 Mar 2015 10:01:16 -0400 Date: Sun, 29 Mar 2015 15:59:23 +0200 From: Borislav Petkov To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Doug Thompson , Mauro Carvalho Chehab , linux-edac@vger.kernel.org Subject: Re: [PATCH 36/86] edac/x38_edac: use uapi/linux/pci_ids.h directly Message-ID: <20150329135923.GE4973@pd.tnic> References: <1427635734-24786-1-git-send-email-mst@redhat.com> <1427635734-24786-37-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1427635734-24786-37-git-send-email-mst@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 29, 2015 at 03:40:32PM +0200, Michael S. Tsirkin wrote: > Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, > use the new header directly so we can drop > the wrapper in include/linux/pci_ids.h. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/edac/x38_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c > index 7c5cdc6..9ce8dd1 100644 > --- a/drivers/edac/x38_edac.c > +++ b/drivers/edac/x38_edac.c > @@ -12,7 +12,7 @@ > #include > #include > #include > -#include > +#include > #include Can you please merge all edac patches into one? Provided people are fine with exporting the PCI defines to userspace, of course. I personally can't think of a reason why not - those are static PCI device numbers and they're in hardware anyway. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --