From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753184AbbC2O1h (ORCPT ); Sun, 29 Mar 2015 10:27:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37328 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752721AbbC2O1f (ORCPT ); Sun, 29 Mar 2015 10:27:35 -0400 Date: Sun, 29 Mar 2015 16:27:17 +0200 From: "Michael S. Tsirkin" To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, Doug Thompson , Mauro Carvalho Chehab , linux-edac@vger.kernel.org Subject: Re: [PATCH 36/86] edac/x38_edac: use uapi/linux/pci_ids.h directly Message-ID: <20150329162622-mutt-send-email-mst@redhat.com> References: <1427635734-24786-1-git-send-email-mst@redhat.com> <1427635734-24786-37-git-send-email-mst@redhat.com> <20150329135923.GE4973@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150329135923.GE4973@pd.tnic> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 29, 2015 at 03:59:23PM +0200, Borislav Petkov wrote: > On Sun, Mar 29, 2015 at 03:40:32PM +0200, Michael S. Tsirkin wrote: > > Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, > > use the new header directly so we can drop > > the wrapper in include/linux/pci_ids.h. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > drivers/edac/x38_edac.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c > > index 7c5cdc6..9ce8dd1 100644 > > --- a/drivers/edac/x38_edac.c > > +++ b/drivers/edac/x38_edac.c > > @@ -12,7 +12,7 @@ > > #include > > #include > > #include > > -#include > > +#include > > #include > > Can you please merge all edac patches into one? > > Provided people are fine with exporting the PCI defines to userspace, of > course. I personally can't think of a reason why not - those are static > PCI device numbers and they're in hardware anyway. OK. I saw they have diff separate entries in maintainers so I wasn't sure it's a good idea, splitting up patches is always a safe thing to do. > -- > Regards/Gruss, > Boris. > > ECO tip #101: Trim your mails when you reply. > --