From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbbC3G6Q (ORCPT ); Mon, 30 Mar 2015 02:58:16 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39589 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbbC3G6P (ORCPT ); Mon, 30 Mar 2015 02:58:15 -0400 Date: Mon, 30 Mar 2015 08:58:10 +0200 From: Greg Kroah-Hartman To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Felipe Balbi , Bjorn Helgaas , Thomas Gleixner , Andy Shevchenko , Andy Lutomirski , Peter Neubauer , Huang Rui , Jean Delvare , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 86/86] usb/dwc3: move ids to pci_ids.h Message-ID: <20150330065810.GA10508@kroah.com> References: <1427635734-24786-1-git-send-email-mst@redhat.com> <1427635734-24786-87-git-send-email-mst@redhat.com> <20150329204200.GB5902@kroah.com> <20150330085001-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150330085001-mutt-send-email-mst@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2015 at 08:50:34AM +0200, Michael S. Tsirkin wrote: > On Sun, Mar 29, 2015 at 10:42:00PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Mar 29, 2015 at 03:43:40PM +0200, Michael S. Tsirkin wrote: > > > Comment says IDs should move to pci_ids.h, let's do it. > > > > No, please remove the comment, it's not needed in pci_ids.h at all. > > vendor ID does belong in pci_ids.h though, so says > Documentation/PCI/pci.txt Read the top of pci_ids.h please.