From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Mon, 30 Mar 2015 13:11:46 +0100 Subject: [PATCH] dmaengine: sa11x0: fix boot-time warning In-Reply-To: <1427708510-17370-1-git-send-email-dbaryshkov@gmail.com> References: <1427708510-17370-1-git-send-email-dbaryshkov@gmail.com> Message-ID: <20150330121146.GG24899@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Mar 30, 2015 at 12:41:50PM +0300, Dmitry Eremin-Solenikov wrote: > Fix the following warning by initializing directions field in the dma_device > structure. > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1 at drivers/dma/dmaengine.c:863 dma_async_device_register+0x2b4/0x4f0() > this driver doesn't support generic slave capabilities reporting > Modules linked in: > CPU: 0 PID: 1 Comm: swapper Not tainted 4.0.0-rc5+ #10 > Hardware name: Sharp-Collie > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (warn_slowpath_common+0x74/0xac) > [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40) > [] (warn_slowpath_fmt) from [] (dma_async_device_register+0x2b4/0x4f0) > [] (dma_async_device_register) from [] (sa11x0_dma_probe+0x21c/0x358) > [] (sa11x0_dma_probe) from [] (platform_drv_probe+0x30/0x94) > [] (platform_drv_probe) from [] (driver_probe_device+0x84/0x234) > [] (driver_probe_device) from [] (__driver_attach+0x98/0x9c) > [] (__driver_attach) from [] (bus_for_each_dev+0x74/0xa4) > [] (bus_for_each_dev) from [] (bus_add_driver+0x13c/0x1e8) > [] (bus_add_driver) from [] (driver_register+0x78/0xf8) > [] (driver_register) from [] (do_one_initcall+0x84/0x1f4) > [] (do_one_initcall) from [] (kernel_init_freeable+0xf8/0x1b4) > [] (kernel_init_freeable) from [] (kernel_init+0x8/0xf0) > [] (kernel_init) from [] (ret_from_fork+0x14/0x2c) > ---[ end trace e188b8fe0e782e75 ]--- > > Signed-off-by: Dmitry Eremin-Solenikov It's an improvement, but I wonder whether src_addr_widths, dst_addr_widths and residue_granularity should also be filled in. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.