From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Ycctp-0005q5-BW
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 12:50:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Ycctl-0007No-Rr
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 12:50:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47278)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Ycctl-0007Nd-Ne
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 12:50:49 -0400
Date: Mon, 30 Mar 2015 17:50:43 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20150330165042.GE2474@work-vm>
References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com>
	<1424883128-9841-9-git-send-email-dgilbert@redhat.com>
	<5516C8FE.5090602@redhat.com>
	<20150329040714.GA9908@voom.fritz.box> <5517BFCB.20304@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5517BFCB.20304@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 08/45] Return path:
 socket_writev_buffer: Block even on non-blocking fd's
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com, David Gibson <david@gibson.dropbear.id.au>

* Paolo Bonzini (pbonzini@redhat.com) wrote:
> 
> 
> On 29/03/2015 06:07, David Gibson wrote:
> > On Sat, Mar 28, 2015 at 04:30:06PM +0100, Paolo Bonzini wrote:
> >> 
> >> 
> >> On 25/02/2015 17:51, Dr. David Alan Gilbert (git) wrote:
> >>> +            if (err != EAGAIN) {
> >> 
> >> if (err != EAGAIN && err != EWOULDBLOCK)
> > 
> > I assume that's for the benefit of non-Linux hosts?  On Linux
> > EAGAIN == EWOULDBLOCK.
> 
> Yes, that's just the standard idiom in QEMU.  This is generic code, so
> assumption based on the host platform are not wise. :)

Done; I didn't know of EWOULDBLOCK - and indeed as far as I can tell
most places we only test for EAGAIN.

> 
> Paolo
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK