Re: [PATCH] ftracetest: Do not use usleep

From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Dave Jones <davej@codemonkey.org.uk>,
	Luis Henriques <luis.henriques@canonical.com>
Subject: Re: [PATCH] ftracetest: Do not use usleep
Date: Mon, 30 Mar 2015 17:15:11 -0400	[thread overview]
Message-ID: <20150330171511.5722493b@gandalf.local.home> (raw)
In-Reply-To: <1427329943-16896-1-git-send-email-namhyung@kernel.org>

On Thu, 26 Mar 2015 09:32:23 +0900
Namhyung Kim <namhyung@kernel.org> wrote:

> The usleep is only provided on distros from Redhat so running ftracetest
> on other distro resulted in failures due to the missing usleep.
> 
> The reason of using [u]sleep in the test was to generate (scheduler)
> events. But as we use 'cat trace | grep | wc -l' to read the events,
> the command themselves already generate some events before reading the
> trace file so no need to call [u]sleep explicitly.

Note, opening "trace" via cat stops tracing. There is a possible race
where the cat will not produce events. My worry is that if the shell
implements its own "cat" command, it may not fork, and open the trace
file. Which would not have any events in it, and opening it will
disable the rest of the command from having events.

What about using:

 ping localhost -c 1

?

-- Steve