From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753570AbbC3TdU (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Mar 2015 15:33:20 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:60038 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753540AbbC3TdO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Mar 2015 15:33:14 -0400
Date: Mon, 30 Mar 2015 21:32:57 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: David Ahern <dsahern@gmail.com>
Cc: Stephane Eranian <eranian@google.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Jiri Olsa <jolsa@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        John Stultz <john.stultz@linaro.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] perf, record: Add clockid parameter
Message-ID: <20150330193257.GE23123@twins.programming.kicks-ass.net>
References: <20150327143201.GG21418@twins.programming.kicks-ass.net>
 <55158F25.9040100@gmail.com>
 <20150327172059.GK23123@twins.programming.kicks-ass.net>
 <551594DD.7050705@gmail.com>
 <20150327201534.GD6291@redhat.com>
 <20150327215942.GL23123@twins.programming.kicks-ass.net>
 <CABPqkBR_ou8E01kRmDOBb72ngcdzBkfVPNUj71XWnsYE6i0Bdg@mail.gmail.com>
 <20150328075549.GG27490@worktop.programming.kicks-ass.net>
 <20150330091735.GK24151@twins.programming.kicks-ass.net>
 <55198522.2070501@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55198522.2070501@gmail.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 30, 2015 at 11:17:22AM -0600, David Ahern wrote:
> On 3/30/15 3:17 AM, Peter Zijlstra wrote:
> >I did this on top..
> >
> >--- a/tools/perf/builtin-record.c
> >+++ b/tools/perf/builtin-record.c
> >@@ -732,13 +732,16 @@ static const struct clockid_map clockids
> >  	/* available for all events, NMI safe */
> >  	CLOCKID_MAP("monotonic", CLOCK_MONOTONIC),
> >  	CLOCKID_MAP("monotonic_raw", CLOCK_MONOTONIC_RAW),
> >-	CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
> >
> >  	/* available for some events */
> >  	CLOCKID_MAP("realtime", CLOCK_REALTIME),
> >  	CLOCKID_MAP("boottime", CLOCK_BOOTTIME),
> >  	CLOCKID_MAP("tai", CLOCK_TAI),
> >
> >+	/* available for the lazy */
> >+	CLOCKID_MAP("mono", CLOCK_MONOTONIC),
> >+	CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
> >+
> 
> how about this one as well:
> CLOCKID_MAP("real", CLOCK_REALTIME),

CLOCK_REALTIME is of limited usability because its not NMI safe.