From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753442AbbC3V17 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Mar 2015 17:27:59 -0400
Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.229]:48664 "EHLO
	cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753083AbbC3V15 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Mar 2015 17:27:57 -0400
Date: Mon, 30 Mar 2015 17:27:55 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
        dave.hansen@linux.intel.com
Subject: Re: [PATCH 04/17] x86, mpx: trace entry to bounds exception paths
Message-ID: <20150330212755.GJ3042@home.goodmis.org>
References: <20150327215253.8583D538@viggo.jf.intel.com>
 <20150327215300.E69E1654@viggo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150327215300.E69E1654@viggo.jf.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-RR-Connecting-IP: 107.14.168.118:25
X-Cloudmark-Score: 0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 27, 2015 at 02:53:00PM -0700, Dave Hansen wrote:
> diff -puN arch/x86/include/asm/trace/mpx.h~x86-mpx-trace-1 arch/x86/include/asm/trace/mpx.h
> --- a/arch/x86/include/asm/trace/mpx.h~x86-mpx-trace-1	2015-03-27 14:35:05.164779793 -0700
> +++ b/arch/x86/include/asm/trace/mpx.h	2015-03-27 14:35:05.169780019 -0700
> @@ -8,6 +8,31 @@
>  
>  #ifdef CONFIG_X86_INTEL_MPX
>  
> +TRACE_EVENT(mpx_bounds_register_exception,
> +
> +	TP_PROTO(void *addr_referenced,
> +		 struct bndreg *bndreg),
> +	TP_ARGS(addr_referenced, bndreg),
> +
> +	TP_STRUCT__entry(
> +		__field(void *, addr_referenced)
> +		__field(u64, lower_bound)
> +		__field(u64, upper_bound)
> +	),
> +
> +	TP_fast_assign(
> +		__entry->addr_referenced = addr_referenced;
> +		__entry->lower_bound = bndreg->lower_bound;
> +		__entry->upper_bound = bndreg->upper_bound;
> +	),
> +
> +	TP_printk("address referenced: 0x%p bounds: lower: 0x%llx ~upper: 0x%llx",
> +		__entry->addr_referenced,
> +		__entry->lower_bound,
> +		~__entry->upper_bound

Hmm, I have to see if libtraceevent handle's that. It might.

-- Steve

> +	)
> +);
> +
>  TRACE_EVENT(bounds_exception_mpx,
>  
>  	TP_PROTO(struct bndcsr *bndcsr),
> diff -puN arch/x86/mm/mpx.c~x86-mpx-trace-1 arch/x86/mm/mpx.c
> --- a/arch/x86/mm/mpx.c~x86-mpx-trace-1	2015-03-27 14:35:05.166779884 -0700
> +++ b/arch/x86/mm/mpx.c	2015-03-27 14:35:05.169780019 -0700
> @@ -16,6 +16,7 @@
>  #include <asm/mmu_context.h>
>  #include <asm/mpx.h>
>  #include <asm/processor.h>
> +#include <asm/trace/mpx.h>
>  #include <asm/fpu-internal.h>
>