On Mon, Mar 30, 2015 at 10:10:05AM +0200, Paolo Bonzini wrote: > > > On 24/03/2015 23:32, David Gibson wrote: > >>> OK, that one I prefer. Are you OK with: > >>> qemu_savevm_state_complete_precopy calls -> > >>> save_live_complete_precopy > >>> > >>> qemu_savevm_state_complete_postcopy calls -> > >>> save_live_complete_postcopy > >>> > >>> ? > > Sounds ok to me. Fwiw, I was thinking that both the > > complete_precopy and complete_postcopy hooks should always be > > called. For a non-postcopy migration, the postcopy hooks would > > just be called immediately after the precopy hooks. > > What about then calling them save_live_after_precopy and > save_live_complete, or having save_live_before_postcopy and > save_live_complete? Good idea. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson