From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yck14-0001CR-HX for qemu-devel@nongnu.org; Mon, 30 Mar 2015 20:26:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yck10-00030H-Do for qemu-devel@nongnu.org; Mon, 30 Mar 2015 20:26:50 -0400 Received: from ozlabs.org ([103.22.144.67]:54592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yck10-000304-2G for qemu-devel@nongnu.org; Mon, 30 Mar 2015 20:26:46 -0400 Date: Tue, 31 Mar 2015 11:10:46 +1100 From: David Gibson Message-ID: <20150331001046.GO9908@voom.fritz.box> References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-21-git-send-email-dgilbert@redhat.com> <20150313010058.GZ11973@voom.redhat.com> <20150313101953.GA2486@work-vm> <20150316061840.GE5741@voom.redhat.com> <20150320123759.GE2468@work-vm> <20150323022542.GG25043@voom.fritz.box> <20150324200414.GG2332@work-vm> <20150324223227.GK25043@voom.fritz.box> <551904DD.4080802@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qnK4RqISe3HuYx1/" Content-Disposition: inline In-Reply-To: <551904DD.4080802@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 20/45] Modify savevm handlers for postcopy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , amit.shah@redhat.com, yanghy@cn.fujitsu.com --qnK4RqISe3HuYx1/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 30, 2015 at 10:10:05AM +0200, Paolo Bonzini wrote: >=20 >=20 > On 24/03/2015 23:32, David Gibson wrote: > >>> OK, that one I prefer. Are you OK with:=20 > >>> qemu_savevm_state_complete_precopy calls -> > >>> save_live_complete_precopy > >>>=20 > >>> qemu_savevm_state_complete_postcopy calls -> > >>> save_live_complete_postcopy > >>>=20 > >>> ? > > Sounds ok to me. Fwiw, I was thinking that both the > > complete_precopy and complete_postcopy hooks should always be > > called. For a non-postcopy migration, the postcopy hooks would > > just be called immediately after the precopy hooks. >=20 > What about then calling them save_live_after_precopy and > save_live_complete, or having save_live_before_postcopy and > save_live_complete? Good idea. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --qnK4RqISe3HuYx1/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVGeYGAAoJEGw4ysog2bOSKfsQAKrXmXSnfiYuUt5flr2lbX4s vy/+o9I9YqQWoPpeX7wMjENBLObxyLJbs8vJPwCj4TJ8ORREQ8+Oi0ZKZSuOtqlv S7lsUmx7YJG/y7n+Kv2mBc2d/Cm8T6sSMtikjs4x4sB5U8r3eoNybN8raNemnMvR vGrZOs+eFazK0UACwptADp5LIoYUelBihKXxzkisrTC0LGyTg/kFT34Alb5eqAaP en1SMs9zpR/Kq/gB+aT3y42q1wCwkHODGysotBjoPA5nnH3BNqFSGSPj8/oyA11p 4ck9lX/NYsGcLpmvCHoNatU5zqHssRXC6jgjF3FkOBaKw8jNRgY4VZiEQW5cRind SK232aiL2f6xZhowaoAGu/cGW2jIeMVUBX4VsaqzrlcDKIvCKyUSWlkoeWseFhiG HD8D399NVtYG0l1H2kQxiHEOZICXX1/DWucn7POxEw4L6QTqQCqb6RVR7G5Slb1k KcrGA2itNAcG5ZwpXZpMcru9LXdjaxiQVozMNNslEuFumamamgYAp9JoVDlie1Yi 1mWhzAFMuN33MNTG0tmhOFrEaMVUhjPrfc4S4NHMDJmED0DlABTVwcABfheiltYd uWsk32G9GSqSdQYJ9BQLEKFSEXwqtJTny0qYqSJNtmMjtA+SMUU9lQIvvWKg8JA6 fwFdhssdQd0I7IsKN7zE =Ifgo -----END PGP SIGNATURE----- --qnK4RqISe3HuYx1/--