* [patch] jffs2: remove an unneeded condition
@ 2015-03-23 9:35 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-03-23 9:35 UTC (permalink / raw)
To: David Woodhouse; +Cc: kernel-janitors, linux-mtd
We know "rc" is set so there is no need to check again.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c
index 762c7a3..2eac553 100644
--- a/fs/jffs2/xattr.c
+++ b/fs/jffs2/xattr.c
@@ -1266,7 +1266,6 @@ int jffs2_garbage_collect_xattr_ref(struct jffs2_sb_info *c, struct jffs2_xattr_
if (rc) {
JFFS2_WARNING("%s: jffs2_reserve_space_gc() = %d, request = %u\n",
__func__, rc, totlen);
- rc = rc ? rc : -EBADFD;
goto out;
}
rc = save_xattr_ref(c, ref);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] jffs2: remove an unneeded condition
@ 2015-03-23 9:35 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-03-23 9:35 UTC (permalink / raw)
To: David Woodhouse; +Cc: kernel-janitors, linux-mtd
We know "rc" is set so there is no need to check again.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c
index 762c7a3..2eac553 100644
--- a/fs/jffs2/xattr.c
+++ b/fs/jffs2/xattr.c
@@ -1266,7 +1266,6 @@ int jffs2_garbage_collect_xattr_ref(struct jffs2_sb_info *c, struct jffs2_xattr_
if (rc) {
JFFS2_WARNING("%s: jffs2_reserve_space_gc() = %d, request = %u\n",
__func__, rc, totlen);
- rc = rc ? rc : -EBADFD;
goto out;
}
rc = save_xattr_ref(c, ref);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] jffs2: remove an unneeded condition
2015-03-23 9:35 ` Dan Carpenter
@ 2015-03-31 0:47 ` Brian Norris
-1 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2015-03-31 0:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, David Woodhouse, linux-mtd
On Mon, Mar 23, 2015 at 12:35:19PM +0300, Dan Carpenter wrote:
> We know "rc" is set so there is no need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Pushed to l2-mtd.git.
Brian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] jffs2: remove an unneeded condition
@ 2015-03-31 0:47 ` Brian Norris
0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2015-03-31 0:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, David Woodhouse, linux-mtd
On Mon, Mar 23, 2015 at 12:35:19PM +0300, Dan Carpenter wrote:
> We know "rc" is set so there is no need to check again.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Pushed to l2-mtd.git.
Brian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-31 0:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-23 9:35 [patch] jffs2: remove an unneeded condition Dan Carpenter
2015-03-23 9:35 ` Dan Carpenter
2015-03-31 0:47 ` Brian Norris
2015-03-31 0:47 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.