From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005AbbCaFcy (ORCPT ); Tue, 31 Mar 2015 01:32:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55624 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbbCaFcx (ORCPT ); Tue, 31 Mar 2015 01:32:53 -0400 Date: Tue, 31 Mar 2015 11:02:39 +0530 From: Amit Shah To: Joe Perches Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , virtualization@lists.linux-foundation.org Subject: Re: [PATCH 12/25] virtio_console: Use bool function return values of true/false not 1/0 Message-ID: <20150331053239.GA9916@grmbl.mre> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (Mon) 30 Mar 2015 [16:46:10], Joe Perches wrote: > Use the normal return values for bool functions > > Signed-off-by: Joe Perches > --- > drivers/char/virtio_console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 72d7028..50754d20 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c > @@ -355,7 +355,7 @@ static inline bool use_multiport(struct ports_device *portdev) > * early_init > */ > if (!portdev->vdev) > - return 0; > + return false; Reviewed-by: Amit Shah Amit From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: [PATCH 12/25] virtio_console: Use bool function return values of true/false not 1/0 Date: Tue, 31 Mar 2015 11:02:39 +0530 Message-ID: <20150331053239.GA9916@grmbl.mre> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Joe Perches Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Arnd Bergmann , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On (Mon) 30 Mar 2015 [16:46:10], Joe Perches wrote: > Use the normal return values for bool functions > > Signed-off-by: Joe Perches > --- > drivers/char/virtio_console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 72d7028..50754d20 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c > @@ -355,7 +355,7 @@ static inline bool use_multiport(struct ports_device *portdev) > * early_init > */ > if (!portdev->vdev) > - return 0; > + return false; Reviewed-by: Amit Shah Amit