Re: [PATCH v6 1/4] perf,record: Add clockid parameter

From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, mingo@elte.hu,
	ak@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org,
	cel@us.ibm.com, sukadev@linux.vnet.ibm.com,
	sonnyrao@chromium.org, johnmccutchan@google.com,
	dsahern@gmail.com, adrian.hunter@intel.com, pawel.moll@arm.com
Subject: Re: [PATCH v6 1/4] perf,record: Add clockid parameter
Date: Tue, 31 Mar 2015 09:28:55 +0200	[thread overview]
Message-ID: <20150331072855.GB12676@worktop.ger.corp.intel.com> (raw)
In-Reply-To: <1427753974-13380-2-git-send-email-eranian@google.com>

On Tue, Mar 31, 2015 at 12:19:31AM +0200, Stephane Eranian wrote:
> @@ -1044,6 +1051,8 @@ static size_t perf_event_attr__fprintf(struct perf_event_attr *attr, FILE *fp)
>  	ret += PRINT_ATTR2(exclude_host, exclude_guest);
>  	ret += PRINT_ATTR2N("excl.callchain_kern", exclude_callchain_kernel,
>  			    "excl.callchain_user", exclude_callchain_user);
> +	ret += __PRINT_ATTR("%u",,use_clockid);
> +
>  
>  	ret += PRINT_ATTR_U32(wakeup_events);
>  	ret += PRINT_ATTR_U32(wakeup_watermark);
> @@ -1056,6 +1065,7 @@ static size_t perf_event_attr__fprintf(struct perf_event_attr *attr, FILE *fp)
>  	ret += PRINT_ATTR_X64(sample_regs_user);
>  	ret += PRINT_ATTR_U32(sample_stack_user);
>  	ret += PRINT_ATTR_X64(sample_regs_intr);
> +	ret += PRINT_ATTR_U32(clockid);
>  
>  	ret += fprintf(fp, "%.60s\n", graph_dotted_line);
>  

You also misplaced a bunch of changes here.