From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753246AbbCaIe4 (ORCPT ); Tue, 31 Mar 2015 04:34:56 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:33811 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752443AbbCaIev (ORCPT ); Tue, 31 Mar 2015 04:34:51 -0400 Date: Tue, 31 Mar 2015 10:34:45 +0200 From: Ingo Molnar To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Bjorn Helgaas , Borislav Petkov Subject: Re: [PATCH 05/86] x86/gart: use uapi/linux/pci_ids.h directly Message-ID: <20150331083445.GB15748@gmail.com> References: <1427635734-24786-1-git-send-email-mst@redhat.com> <1427635734-24786-6-git-send-email-mst@redhat.com> <20150330052936.GA5055@gmail.com> <20150330085249-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150330085249-mutt-send-email-mst@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Michael S. Tsirkin wrote: > On Mon, Mar 30, 2015 at 07:29:36AM +0200, Ingo Molnar wrote: > > > > * Michael S. Tsirkin wrote: > > > > > Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, > > > use the new header directly so we can drop > > > the wrapper in include/linux/pci_ids.h. > > > > > > Signed-off-by: Michael S. Tsirkin > > > --- > > > arch/x86/kernel/aperture_64.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c > > > index 76164e1..3b52a56 100644 > > > --- a/arch/x86/kernel/aperture_64.c > > > +++ b/arch/x86/kernel/aperture_64.c > > > @@ -17,7 +17,7 @@ > > > #include > > > #include > > > #include > > > -#include > > > +#include > > > #include > > > #include > > > #include > > > -- > > > MST > > > > > > > NAK, it's absolutely ridiculous to send a 86 patches series for a > > trivial change like this! > > > > Just do the rename in a single patch and avoid the churn. Even if > > there are conflicts, they are utmost trivial to fix up. > > > > In fact the usual way to do such renames is to wait until the end of > > -rc1, auto-generate it and send Linus the core patch with the trivial > > renames straight away. > > > > Thanks, > > > > Ingo > > > Unfortunately, vger mailing lists reject any email with more than 2k of > email headers. This means if I do what you suggest I can't Cc all > maintainers for all affected files. [...] You can Cc: linux-arch and lkml for tree-wide changes. Also, since it's mostly trivial, there shouldn't be much (if any) controversy about it, right? > [...] I could just Cc all mailing lists I guess, but I really > wasn't sure about some parts of the change, deferring it until end > of -rc1 wouldn't be appropriate in this case, would it? So since 90% of the patches are just a trivial: -#include +#include you can auto-generate that simple rename and file movement into a single commit, at the end of -rc1, without affecting anyone, via something like: sed -i 's/linux\/pci_ids.h/uapi\/linux\/pci_ids.h/g' $(git grep -l linux/pci_ids.h) git mv include/linux/pci_ids.h include/uapi/linux/pci_ids.h git commit -a (totally untested) This should just work. Any other changes, as the removal of inclusions from files that apparently don't need it, or cleanups like the changing of the guard defines in pci_id.h, can be done on top of that - on a one patch per change basis. This should drastically remove the churn. What do you think? Thanks, Ingo