From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753154AbbCaJD4 (ORCPT ); Tue, 31 Mar 2015 05:03:56 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38407 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbbCaJDz (ORCPT ); Tue, 31 Mar 2015 05:03:55 -0400 Date: Tue, 31 Mar 2015 11:03:49 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Joe Perches , linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0 Message-ID: <20150331090349.GA16604@gmail.com> References: <93bd3fb8db14c75508f7169840824539a3f89606.1427759010.git.joe@perches.com> <20150331085320.GR27490@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150331085320.GR27490@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > On Mon, Mar 30, 2015 at 04:46:17PM -0700, Joe Perches wrote: > > Use the normal return values for bool functions > > > > Update the other sets of ret in try_wait_for_completion. > > I'm missing a why; why are you doing this? Let me guess: Joe Perches is suffering from 'trivialititis': a sickness that prevents a non-newbie kernel developer from raising beyond churning out a flood of trivial patches and creating unnecessary churn for other developers with these borderline useless patches? Linux is a meritocracy, not a bureaucracy. Thanks, Ingo